Skip to content

Create a health check dashboard section #13 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChiuchiuSorin merged 90 commits into from
Jan 16, 2024
Merged

Create a health check dashboard section #13 #19

ChiuchiuSorin merged 90 commits into from
Jan 16, 2024

Conversation

@ChiuchiuSorin
Copy link
Collaborator

@ChiuchiuSorin ChiuchiuSorin commented Oct 30, 2023

Dashboard section (log messages will be modified):
image

Help links section:
image

@ChiuchiuSorin
Create the pom structure of the application xwikisas#1
6078db0 
Created the pom structure of the project
@ChiuchiuSorin
Create the pom structure of the application xwikisas#1
6939275
@ChiuchiuSorin
Create the pom structure of the application xwikisas#1
04a62b8
@ChiuchiuSorin
Display App server info xwikisas#3
046cb6d
@ChiuchiuSorin
Display App server info xwikisas#3
5b62df5
@ChiuchiuSorin
Display App server info xwikisas#3
00ad0f6
@ChiuchiuSorin
Display App server info xwikisas#3
5794faf
@ChiuchiuSorin
try resolve merge issue
08afe11
@ChiuchiuSorin
Display App server info xwikisas#3
d3aab58
@ChiuchiuSorin
Display App server info xwikisas#3
63b0fb8
@ChiuchiuSorin
Merge branch 'main' into config-info
ccaf7c7 
# Conflicts:
#	application-admintools-default/pom.xml
#	application-admintools-default/src/main/resources/META-INF/components.txt
@ChiuchiuSorin
isplay App server info xwikisas#3 - debug
853d8c5
@ChiuchiuSorin
Display App server info xwikisas#3
2d3de9e 
- Created an interface and abstract class DataProvider for better generalization and  future extension of the components that provide data.
- Created templates for data gathering components.
@ChiuchiuSorin
Display App server info xwikisas#3
9345101 
Rewrited some of the comments and corrected some typos.
@ChiuchiuSorin
Display App server info xwikisas#3
e9bc0f4 
Code refactoring
@ChiuchiuSorin
Download important files xwikisas#8 - DRAFT
7439f99
@ChiuchiuSorin
Display App server info xwikisas#3
fa91965
@ChiuchiuSorin
Merge branch 'config-info' into files-logs-download
82ad541
@ChiuchiuSorin
Display App server info xwikisas#3
57cebb5
@ChiuchiuSorin
Download important files xwikisas#8
a1096b3
@ChiuchiuSorin
Download important files xwikisas#8
a2a79ba
@ChiuchiuSorin
Download important files xwikisas#8
1d56ff4 
- Removed the download logs endpoint
- Added an endpoint for downloading a multiple files archive
- Added function for data providers to return info json
- Added script function to retrieve the context path
@ChiuchiuSorin
Display App server info xwikisas#3
f2e164a
@ChiuchiuSorin
Download important files xwikisas#8
6f5aff4
@ChiuchiuSorin
Download important files xwikisas#8
ed557e0 
- added logs viewer endpoint
- merged with config-info
@ChiuchiuSorin
Download important files xwikisas#8 - DRAFT
8cc8c1d
@ChiuchiuSorin
Display App server info xwikisas#3
0e4c97f
@ChiuchiuSorin
Display App server info xwikisas#3
2476cb1
@ChiuchiuSorin
Display App server info xwikisas#3
00c1c25
@ChiuchiuSorin
Display App server info xwikisas#3
c8d3208
mflorea
mflorea requested changes Nov 10, 2023
View reviewed changes
@ChiuchiuSorin
Merge remote-tracking branch 'origin/main' into health-check
ce52ac2 
# Conflicts:
#	application-admintools-default/src/main/resources/templates/configurationTemplate.vm
#	application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm
#	application-admintools-default/src/main/resources/templates/securityTemplate.vm
#	application-admintools-ui/src/main/resources/AdminTools/Code/AdminToolsJS.xml
#	application-admintools-ui/src/main/resources/AdminTools/Code/Configuration.xml
#	application-admintools-ui/src/main/resources/AdminTools/Code/ConfigurationClass.xml
#	application-admintools-ui/src/main/resources/AdminTools/Code/Macros.xml
#	application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml
#	application-admintools-ui/src/main/resources/AdminTools/WebHome.xml
@ChiuchiuSorin
Create a health check dashboard section xwikisas#13 - backup
d56a333
@ChiuchiuSorin
Create a health check dashboard section xwikisas#13
aec872e 
* Modified the test structure
* Adpated health checks to the usage of HealthCheckResult
* Added tests to be able to return a result for every tested data
* Created HealthCheckMacros
* Created macro for generating job status info
* Created macros for displaying the HealthCheckresults in the UI
* Added the posibility to extend a result in the UI to see a more detailed explanation or suggestion
* Added coments
* Addded and modified translations
* Adapted tests and added new tests for the new classes
* Other small modification in JS and backend
@ChiuchiuSorin
Create a health check dashboard section xwikisas#13
0cb5093 
* Adapted the request for job.js in AdminToolsJs to be initialized only once
* Added grouping for the job
* Created function to generate the job id inside the script service
*  Refactored the help links
* Refactored the HealthCheckMacros and HealthCheckResources
@ChiuchiuSorin
Copy link
Collaborator Author

ChiuchiuSorin commented Nov 17, 2023

Health check interface:
image
Warning and error result expansion (code was modified to see the result as an error for display purposes):
Result expanded:
image
Result not expanded:
image

@ChiuchiuSorin
Create a health check dashboard section xwikisas#13
18d6765 
* Fixed missing CSS class selector
oanalavinia
oanalavinia requested changes Nov 23, 2023
View reviewed changes
@oanalavinia oanalavinia linked an issue Nov 23, 2023 that may be closed by this pull request
Create a health check dashboard section #13
Closed
@oanalavinia oanalavinia changed the title Health check Create a health check dashboard section #13 Nov 23, 2023
@ChiuchiuSorin ChiuchiuSorin mentioned this pull request Nov 27, 2023
Merged
mflorea
mflorea requested changes Dec 7, 2023
View reviewed changes
@ChiuchiuSorin
Create a health check dashboard section xwikisas#13
76711b9 
* Refactored translations
* Refactored tests
*  Modified HealthCheckResult java class
* Created an enum for health check results
* Added admin verification for script service
* Refactored checks
mflorea
mflorea requested changes Dec 8, 2023
View reviewed changes
@ChiuchiuSorin
Create a health check dashboard section xwikisas#13
190f876 
* modified script service admin check
* small code refactoring in macros, javascript and Health check
oanalavinia
oanalavinia requested changes Jan 8, 2024
View reviewed changes
@ChiuchiuSorin
Create a health check dashboard section xwikisas#13
a8cdeea 
* modified comments
* fixed identation
* code refactoring
mflorea
mflorea approved these changes Jan 16, 2024
View reviewed changes
Copy link

@mflorea mflorea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with only a minor comment. Fix that and we can merge. Well done @ChiuchiuSorin !

oanalavinia
oanalavinia approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment:)

@ChiuchiuSorin ChiuchiuSorin merged commit 8a48861 into xwikisas:main Jan 16, 2024
@ChiuchiuSorin ChiuchiuSorin deleted the health-check branch January 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mflorea mflorea mflorea approved these changes

@oanalavinia oanalavinia oanalavinia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a health check dashboard section

3 participants

@ChiuchiuSorin @mflorea @oanalavinia