Deleted user appears in the Poll Live table once the Status is changed to Finish

[ane-gabriela]

Preconditions: Have several users already created on the wiki.

Steps to reproduce:

1. Create a Poll, Status Active
2. Vote for it with multiple users
3. Log in as Admin
4. From Administer Wiki > Users & Rights > Users delete one of the voting users
5. Go back to the Poll
6. Edit it and change the status to Finished

Expected results: The deleted user doesn't appear anymore in the Poll if he was removed while the poll was still Active - as per ticket #48

Actual results: The deleted user disappears from the Poll once the Admin deletes him but once the status of the Poll is changed to Finish the user appears again in the livetable and his vote is counted.

Environment: Windows 10, XWiki 9.11 Standard, Polls Application (Pro) 2.0

[CamiAndrei]

This was done on purpose. if you follow the comments from the #48 ticket. That is why the deleted users are displayed with the grey colour, so they could be identified as deleted user, but know all the users that voted.

[silviamacovei]

I think this issue is valid. I see the following cases:

1. user active > poll finished > user black > vote counted in finished poll results
2. user active > poll active > user black > vote counted in finished poll results
3. user becomes inactive while poll finished > user gray > vote counted in finished poll results
4. user becomes inactive while poll active > user deleted > vote not counted in finished poll results

The fix on ticket #48 covers the first 3 cases. The present issue refers to case 4.

[ane-gabriela]

Reopening as this issue is valid, as Silvia also commented.

[CamiAndrei]

@silviamacovei Have you tested the cases?
As I remember, when Poll is finished are counted all the displayed votes, including the votes of the deleted users.

[mflorea]

@CamiAndrei the key here is that the user was deleted while the poll was still active and so we shouldn't count nor list this user. Deleted users should be listed only if they were deleted after the poll was closed.

[acotiuga]

We need an event listener to catch the user deletion when the poll is in active state and remove the corresponding vote.