fix: #25 Fixes vim:E976 error when cursor is on a blob.#28
Open
fix: #25 Fixes vim:E976 error when cursor is on a blob.#28
Conversation
alanchenvon
approved these changes
Jul 12, 2023
|
Hello! I see that PR approved, but not merged. I also get this error from issue. @alanchenvon please merge that PR if all ok. And thanks @rpopic2 for that fix! |
Owner
|
Thanks for working on this fix. I reviewed the patch with Issue #25 in mind, and I think we should adjust a few points before merge:
The blob type guard is a good direction, but these changes would make the fix safer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error executing lua callback: Vim:E976: using Blob as a String #25
Open any binary file, move cursor on a blob(blue characters starting with ^), throws vim:E976.
This error is thrown when blob is provided for function
vim.fn.matchstr(), instead of a string.matchadd()(line 12),fn.type(line)is avim.v.t_blob.I tried reproducing the bug as I mentioned above, and it was fixed.
Testing environment: MacOS Ventura 13.1, Apple M2, nvim v0.8.3