Skip to content

Hi, I refactored some stuff #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pnevares wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Hi, I refactored some stuff #2

pnevares wants to merge 38 commits into from

Conversation

@pnevares
Copy link

@pnevares pnevares commented Apr 17, 2018

👋

Pablo Nevares and others added 30 commits April 16, 2018 10:47
Scoped Game, replaced add/removeCell with toggle for simpler event.bu…
ad53ea1 
…ttons use, combined script tags
Redraw after random seed, simpler cloneCellArray with array spread
0079916
Simpler colorArray iteration
e911b76
Use array map for seedRandomly
76d881d
Using a different button property for each event
723be80
Fixed seedRandomly bug, using forEach for redraw
c8c9e79
Shortened redraw
050105c
Fixed colorCellsCycle
3a3ff89
Filling initial cells with the array constructor
32ba921
Cells are now boolean instead of number
a1fc1b3
Strict equality for some comparisons
1552b73
Fixing random seed
59ad564
Merged hideCell into drawCell
861a6f1
Fixing initial cell state bug
4fd5951
Fixing initial cell state bug
db73a03
Simpler neighbor check, refactor initial cell state
f9da9b6
Use template literals for rgb strings, normalize to double-quotes
a393aad
Keep a colorCells setting, use array destructure for colorArray
40a07f5
Resolved merge conflict
0a26e61
Refactored color generation, removed shadowed variables
b83a633
Removed minimized function
a174f84
Using array functions to iterate inside of processCells
74a21de
Using map to set cells with applyRules
720f826
Refactored to remove currentCells
7467b0f
Cleaned equality checks, made processing a bool, merged redundant ste…
aed7700 
…p/start methods
Array destructure to set initial color channels
4ae1db9
Converted Game to a class
eeb70bf
Re-use canvas context, make color object a dumb array
1ae3ccd
Removed redundant canvas clear
ad14f09
@pnevares
Formatted with prettier
e6e0277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pnevares