Support the new protocol node format:#29
Merged
bneradt merged 1 commit intoyahoo:masterfrom Jul 17, 2020
Merged
Conversation
Member
|
Do you really want a list instead of a map? I think it's fundamental that none of the protocol stack tags will be duplicated. E.g. |
Collaborator
Author
Keeping it a sequence was Masakazu's influence: You can see the discussion there. He had some good observations that convinced me that maintaining it as a sequence made sense. Since it is a protocol stack, order matters and technically order is not preserved in a map. |
"sessions": [
{
"protocol": [
{
"name": "http",
"version": "2"
},
{
"name": "tls",
"version": "TLSv1.2",
"sni": "www.tls.com",
"proxy-verify-mode": 0,
"proxy-provided-cert": true
},
{
"name": "tcp"
},
{
"name": "ip",
"version": "4"
}
],
...
"proxy-request": {
"protocol": [
{
"name": "http",
"version": "1.1"
},
{
"name": "tls",
"version": "TLSv1.2",
"sni": "www.tls.com",
"proxy-verify-mode": 1,
"proxy-provided-cert": false
},
{
"name": "tcp"
},
{
"name": "ip",
"version": "4"
}
],
386b6fc to
a97d02a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.