Updates to PR#107 which was mostly done#110
Merged
dwighthubbard merged 24 commits intomasterfrom Jun 28, 2022
Merged
Conversation
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
- Handle both ssh and https git urls - Update the project_urls configuration argument that setuptools expects - Add more through tests to bring coverage of the new code to 100%
tzunieh
reviewed
Jun 28, 2022
tzunieh
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on PR#107 which hasn't seen any work for quite a while.
This PR makes the following changes:
Motivation and Context
PR#107 hasn't seen any progress in quite a while
How Has This Been Tested?
New code has full test coverage.
Types of changes
Checklist:
License
I confirm that this contribution is made under a Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.