Skip to content

Add Solaris compilation fix from Perl binding repo.#16

Open
ingydotnet wants to merge 1 commit into
masterfrom
solaris-fix
Open

Add Solaris compilation fix from Perl binding repo.#16
ingydotnet wants to merge 1 commit into
masterfrom
solaris-fix

Conversation

@ingydotnet
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really love a way to ensure this doesn't regress. Is there a way we can run make test on Solaris-ish systems via Docker?

@ingydotnet
Copy link
Copy Markdown
Member Author

Originally from Andy Grundman andyg@activestate.com circa August 2014.

Not sure if we can get a solaris test env. I can ask around.

@sigmavirus24, what's the current state of CICD for libyaml?

@sigmavirus24
Copy link
Copy Markdown
Contributor

@ingydotnet the current state is only on Travis, although I'm looking at how we can get stuff running on Windows with AppVeyor. Unfortunately, windows is not my strong suit so I think I'm going to simply make an issue for someone to tackle if they know what they're doing.

@ingydotnet
Copy link
Copy Markdown
Member Author

@sigmavirus24 think we can go ahead and apply this?

Since we don't have CI testing for solaris, releasing it would likely get someone to complain if it breaks anything. Then we ask the person reporting the bug to do our CI!!! :)

@ingydotnet ingydotnet mentioned this pull request Jan 7, 2018
@sigmavirus24
Copy link
Copy Markdown
Contributor

🤷‍♀️ I guess?

@ingydotnet
Copy link
Copy Markdown
Member Author

@sigmavirus24, I was kinda kidding. Mostly this is a simple patch and we've
been sitting on it for a year. No idea how much solaris usage we have.

@ingydotnet
Copy link
Copy Markdown
Member Author

@hanetzer @sigmavirus24 @perlpunk I had to a merge conflict with some other new ifdef stuff, and I wanted to make sure it looks right.

It looked right to me and all the CI tests pass, but please review. Cheers...

@ingydotnet
Copy link
Copy Markdown
Member Author

@andygrundman Hi. Your Solaris patch for YAML::XS just made it into libyaml.

Was wondering if you or ActiveState had any resources for CICD testing on Solaris or HPUX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants