change dllexport controlling macro to use _WIN32 #66
Merged
Conversation
…mpiler) instead of WIN32 (which is user configurable, and omitted by default on some x64 builds); this fixes an issue with 64 bit windows static library builds
Member
|
@marksheahan Thanks for the PR. I don't have a way to test this out yet. I wonder if it can be done on Appveyor CI/CD? Is there a no-cost toolchain that I can point one of our windows devs at to test/review this? Glances at @hanetzer ... |
Contributor
|
@ingydotnet mingw-w64 is a very good toolchain, basically gcc for windows, no cost. |
Member
|
@hanetzer I meant a msvc free compiler to test with. I think MS offers such a thing, but it's been a long time... |
Contributor
|
@ingydotnet did you not notice that the appveyor cmake builds are happening with the windows toolchains? |
Contributor
Author
|
I'm not sure how to get a free toolchain. MSVC has a free edition but it
requires windows. Not sure if it will run on wine.
I wanted a static library just to simplify deployment, and for consistency
with our other targets (osx, linux, solaris)
…On Jan 7, 2018 4:30 PM, "hanetzer" ***@***.***> wrote:
@ingydotnet <https://github.com/ingydotnet> did you not notice that the
appveyor cmake builds are happening with the windows toolchains?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#66 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADLnFRtvWd3W9uF2s-wSoEPWgUhLa8flks5tIWHAgaJpZM4QntmI>
.
|
Member
perlpunk
approved these changes
Apr 11, 2020
Member
|
Thanks, merged! |
perlpunk
pushed a commit
that referenced
this pull request
Apr 11, 2020
(provided by msvc compiler) instead of WIN32 (which is user configurable, and omitted by default on some x64 builds); this fixes an issue with 64 bit windows static library builds (#66) Co-authored-by: Mark Sheahan <mark.sheahan@upguard.com>
egli
added a commit
to liblouis/liblouis
that referenced
this pull request
Aug 25, 2020
for some (unknown) reason only this version will create a lou_checkyaml.exe that has libyaml statically linked in. Believe me, I tried with 0.2.1, 0.2.2 and 0.2.5 and none of them had libyaml statically included. There is a remark in yaml/libyaml#66 (comment) which indicates that at some point they weren't even shared windows libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use _WIN32 which is provided by msvc compiler, instead of WIN32 which is user configurable, and omitted by default on some x64 builds.
I'm still needing to do:
#define YAML_DECLARE_STATIC
#include <yaml.h>
in my own code on windows builds to avoid dllimport when using libyaml as a static library, but this is acceptable.