Skip to content

Refactor All The Things #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yanone merged 39 commits into from
Dec 10, 2025
Merged

Refactor All The Things #8

yanone merged 39 commits into from
Dec 10, 2025

Conversation

@simoncozens
Copy link
Contributor

@simoncozens simoncozens commented Dec 9, 2025

OK, this is a massive change. However, it's a good one.

  • Moves all font access to font manager.
  • Splits up glyph canvas even more, including splitting out outline editor
  • Uses webpack for bundling/CORS/etc.
  • Removes some vendored modules, uses npm instead
  • Uses JSON as the source of truth for font edits
  • Removes a lot of superfluous Python calls
  • Adds some UI candy around dragging handles

Everything seems to work apart from:

  • Interpolation of glyph outlines during sliding. The interpolated glyph compiles and sends back a valid outline, but it doesn't seem to be displayed in the outline editor. I'll fix that soon.

@simoncozens
A wild LayerDataNormalizer appeared!
d713e9c
@simoncozens
A wild shapeTextWithFont appeared!
7328ef0
@simoncozens
Refactor repeated code for getting glyph name
1096a31
@simoncozens
Lint fix
92f913e
@simoncozens
Move fetchComponentLayerData to font manager
930c84c
@simoncozens
Move fetchRootLayerData to font manager
62f1ad5
@simoncozens
Move onFontLoaded to font manager
0ac36de
@simoncozens
Who needs Python when you have a JSON object handy?
b94ca8d
@simoncozens
Move fetchGlyphData to the font manager
5549b53
@simoncozens
Move more Python into font manager
9e11206
@simoncozens
Moved more Python to JS
025c2dc
@simoncozens
Move all rendering functions to a separate renderer - temporary fix t…
e20036a 
…o aid more refactors
@simoncozens
Convert to webpack/TS
bd1b093
@simoncozens
Typescriptify a few more things
ce3f348
@simoncozens
More typescript
62340b9
@simoncozens
Add bidi dependency, convert some more files
9c7f693
@simoncozens
Remove loaded modules, use npm opentype
e880a17
@simoncozens
Convert glyph canvas to TS
5ed8150
@simoncozens
No longer needed as endpoints, imported instead
ed6491d
@simoncozens
Tidy up some typings
c4098ab
@simoncozens
One single entry point
2b1b08d
@simoncozens
Fixup use of opentype library
d830aec
@simoncozens
Restore loading animation/tab handler
d7a092f
@simoncozens
Many more tests
3186c3b
@simoncozens
Single point of entry
72fe062
@simoncozens
Separate out outline editor
a2c5bf8
@simoncozens
Add some more typings
469180f
@simoncozens
JSON data is now the source of truth, which means we can type Layers.
c95df4f
@simoncozens
Tidy up
c54e924
@simoncozens
Move handles in parallel with nodes and with each other
fe3b1cd
@yanone yanone merged commit b037125 into yanone:main Dec 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simoncozens @yanone