default_types parameter is now recursively used + improve CLI + Pydantic v2
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaheuxPEREN
force-pushed
the
rec_default_types_and_pydantic_v2
branch
from
4209bbb to
51e29b4
Compare
Owner
|
Hi @emaheuxPEREN thanks for you contribution! This library is has not been maintained for a long time. It may be hard to make such big change in one PR. Could you please separate into multi PRs? I can also review the changes more easily. About the first feature, About moving to pydantic v2, i think it's not enough to just replace the import with About typing issues, i have migrated my projects into uv + ruff + pyright (with standard mode). I will update the project configures. |
…g issues + default_types parameter is now recursively used + minor improvement on CLI
…d class (deriving from int) to spot them easily
emaheuxPEREN
force-pushed
the
rec_default_types_and_pydantic_v2
branch
from
dd3436f to
cbf3b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_typesparameter is now recursively used (+ add newZERO_TAG_INT8type for convenience) so that usingdefault_types={0: types.INT8, 12: types.ZERO_TAG_INT8}enable to decode byte as int8