Skip to content

dataset download eta#2351

Open
martastn wants to merge 3 commits intomasterfrom
2350-display-estimated-time-remaining-for-simulation-dataset-download
Open

dataset download eta#2351
martastn wants to merge 3 commits intomasterfrom
2350-display-estimated-time-remaining-for-simulation-dataset-download

Conversation

@martastn
Copy link
Copy Markdown
Contributor

@martastn martastn commented Mar 30, 2026

This pull request enhances the user experience of the Geant4 dataset download UI by adding a real-time estimated time remaining indicator during downloads and improving the behavior of the dataset accordion. The main changes are focused on providing better feedback to users about download progress and making the UI interactions more intuitive.

Download progress and estimation improvements:

  • Added a new function formatTime and logic to calculate and display an estimated time remaining for dataset downloads, smoothing the speed calculation for more accurate estimates. The estimated time is shown next to the dataset name during downloads. [1] [2]

UI/UX enhancements:

  • Modified the accordion summary click handler to stop event propagation, preventing unintended side effects when toggling the open state of dataset accordions.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an estimated time remaining (ETA) indicator to the Geant4 dataset download UI, improving user feedback during long downloads.

Changes:

  • Compute a smoothed download speed per dataset and derive an ETA string for the DOWNLOADING state.
  • Update dataset status rendering to show the ETA next to the dataset name.
  • Adjust the accordion summary click handler (adds stopPropagation) and extend progress bar mapping to include IDLE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx Outdated
Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx
Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx
Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx Outdated
martastn and others added 2 commits March 30, 2026 14:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx
Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx
Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx
Comment thread src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx
@grzanka
Copy link
Copy Markdown
Contributor

grzanka commented Mar 30, 2026

The progress bars gets into unknown state when I refresh the page (to stop download) in the middle of the download process.

I would expect that after refresh and page reload the "progress bars" would be sliding left and right but stand still...

Take a look around second 13...

simplescreenrecorder-2026-03-30_16.43.10.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display estimated time remaining for simulation dataset download

3 participants