Random ray sdp init#3
Draft
yardasol wants to merge 31 commits intorandom-ray-sdp-mainfrom
Draft
Conversation
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
6f75018 to
0e24aa3
Compare
- change scope of variables to public to simplify logic - fix bdf_ vector initialization
- coefficients - fucntions to update the bdf vectors
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
9dd1032 to
1550fa4
Compare
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
d4f43a8 to
81a96be
Compare
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
111b35d to
0964c97
Compare
yardasol
force-pushed
the
random-ray-sdp-init
branch
3 times, most recently
from
7d5a55e to
116c31a
Compare
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
116c31a to
2f7e10e
Compare
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
32aae49 to
e2ac3ec
Compare
- add k_eff normalization - add checks for zero-valued cross sections - fix numerical derivatives - fix statepoint filename change
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
e2ac3ec to
8901519
Compare
- fix time-dependent statepoints not writing - change bdf order location to allow for updating - store analytic source as needed for timesteps instead of Q/sigma_t (this breaks the tests but the values are approximately correct, still need to propogate this change to the linear source domain) - use truncated SDP for simplicity (we will change this later but for now this will do)
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
43b2b26 to
cac1a00
Compare
yardasol
force-pushed
the
random-ray-sdp-init
branch
from
8859a51 to
cf43e5e
Compare
yardasol
commented
Jan 16, 2025
Comment on lines
+647
to
+651
| void RandomRaySimulation::point_to_bdf_vectors() { | ||
| domain_->scalar_flux_bdf_ = &random_ray_td::scalar_flux_bdf_; | ||
| domain_->source_bdf_ = &random_ray_td::source_bdf_; | ||
| domain_->precursors_bdf_ = &random_ray_td::precursors_bdf_; | ||
| } |
Owner
Author
There was a problem hiding this comment.
This has been removed in new bracnch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Source Derivative Propagation for time-dependent random ray transport using flat source regions.
This PR also updates the python
MGXSmodule with functionality to generate MGXS libraries for random ray transport.Fixes # (issue)
Checklist