fix: remove class from props in reset button component#106
Merged
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the FacetWP reset button Blade component so external class attributes are no longer stripped from the ComponentAttributeBag, making it possible to pass classes in from the component caller.
Changes:
- Removed
classfrom@propsto prevent Blade from extracting/filtering theclassattribute out of$attributes. - Switched from
$attributes->merge(['class' => ...])to$attributes->class(...)->merge()to support conditional class composition more easily.
rivanuff
approved these changes
Apr 29, 2026
laravdiemen
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Als
classin@propsstaat wordt deze uit deComponentAttributeBaggefilterd en is het niet mogelijk om van buitenaf een class mee te geven.Verder is
class()losgemaakt vanmerge(), dat maakt het makkelijker om conditionele classes toe te voegen net als met@class.