Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3d6a0f8
feat: use Navi for primary navigation
WybeBosch Jan 29, 2026
d9f72a4
feat: update primary navigation initialization
Yannicvanveen Feb 18, 2026
45009a4
feat: replace arbitrary group classes
Yannicvanveen Feb 18, 2026
d5553e9
feat: clearer group name / replace padding with gap / move list reset…
Yannicvanveen Feb 18, 2026
a48623c
feat: implement Navi in footer
Yannicvanveen Feb 18, 2026
bf73810
feat: implement Navi in top bar
Yannicvanveen Feb 18, 2026
1c85900
feat: remove top-bar.css
Yannicvanveen Feb 18, 2026
854bf02
fix: use correct values and selectors for updating --top-bar-height
Yannicvanveen Feb 18, 2026
c70a7a5
feat: add NaviComposer
Yannicvanveen Feb 18, 2026
bc06d64
feat: implement Navi top bar navigation in mobile menu
Yannicvanveen Feb 18, 2026
0edcb9f
feat: implement Navi primary navigation in mobile menu
Yannicvanveen Feb 18, 2026
d587921
fix: aria-current conditions
Yannicvanveen Feb 18, 2026
88dfd26
feat: use gap for primary nav list
Yannicvanveen Feb 18, 2026
4b970f6
chore: regenerate lockfile after rebase
YvetteNikolov Mar 3, 2026
65604dc
refactor: move mobile-menu.css into blade template
YvetteNikolov Mar 3, 2026
8f07a21
style: small styling changes
YvetteNikolov Mar 3, 2026
b959728
fix: add ->classes to all navigation items
YvetteNikolov Mar 3, 2026
e2ee73d
refactor: text-primary-* to text-primary
YvetteNikolov Mar 4, 2026
51c5d1d
feat: first step of integrating the components and optimized frontend js
YvetteNikolov Mar 4, 2026
7b02c5d
feat: refactor to using item only on link, and using data-mode attribute
YvetteNikolov Mar 5, 2026
a0d15f5
chore: change navigation toggle <i> to <svg>
YvetteNikolov Apr 14, 2026
4d7d441
chore: regenerate lockfile after rebase
YvetteNikolov Apr 14, 2026
37bf307
style: remove list-reset classes after rebase
YvetteNikolov Apr 14, 2026
2f77ac1
chore: update @yardinternet/brave-frontend-kit
YvetteNikolov Apr 14, 2026
adf7d9d
chore: feedback
YvetteNikolov Apr 14, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ registry=https://registry.npmjs.org
minimum-release-age=10080

# Exclude own packages from minimum release age check
minimum-release-age-exclude=@yardinternet
minimum-release-age-exclude=@yardinternet/*

1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"composer/installers": "^2.2",
"gravitykit/gravity-forms-zero-spam": "^1.7",
"johnbillion/user-switching": "^1.11",
"log1x/navi": "^3.1",
"log1x/poet": "^2.0",
"lukasbesch/bedrock-plugin-disabler": "^1.4",
"oscarotero/env": "^2.1",
Expand Down
405 changes: 268 additions & 137 deletions composer.lock

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@
"yard-toolkit": "yard-toolkit"
},
"devDependencies": {
"@yardinternet/eslint-config": "^1.2.5",
"@yardinternet/prettier-config": "^2.0.5",
"@yardinternet/stylelint-config": "^1.1.4",
"@yardinternet/toolkit": "^2.1.3",
"@yardinternet/vite-config": "^1.1.2",
"@yardinternet/eslint-config": "^1.2.7",
"@yardinternet/prettier-config": "^2.0.6",
"@yardinternet/stylelint-config": "^1.1.5",
"@yardinternet/toolkit": "^2.1.4",
"@yardinternet/vite-config": "^1.2.1",
"tailwindcss": "^4.2.0",
"vite": "^7.3.1"
},
"dependencies": {
"@yardinternet/a11y-cookie-yes": "^1.2.12",
"@yardinternet/brave-frontend-kit": "^0.7.3",
"@yardinternet/brave-frontend-kit": "^0.8.0",
"@yardinternet/gutenberg-block-restrictions": "^1.0.1",
"@yardinternet/gutenberg-components": "^1.3.3"
},
Expand Down
1,968 changes: 564 additions & 1,404 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

48 changes: 48 additions & 0 deletions web/app/themes/sage/app/View/Composers/NaviComposer.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?php

declare(strict_types=1);

namespace App\View\Composers;

use Log1x\Navi\Navi;
use Roots\Acorn\View\Composer;

class NaviComposer extends Composer
{
/**
* List of views served by this composer.
*
* @var array
*/
protected static $views = [
'components.header.*',
'sections.footer',
];
Comment thread
YvetteNikolov marked this conversation as resolved.

/**
* Data to be passed to view before rendering, but after merging.
*/
public function override(): array
{
return [
'footerNavigation' => $this->footerNavigation(),
'primaryNavigation' => $this->primaryNavigation(),
'topBarNavigation' => $this->topBarNavigation(),
];
}

public function footerNavigation(): Navi
{
return Navi::make()->build('footer_navigation');
}

public function primaryNavigation(): Navi
{
return Navi::make()->build('primary_navigation');
}

public function topBarNavigation(): Navi
{
return Navi::make()->build('top_bar_navigation');
}
Comment thread
YvetteNikolov marked this conversation as resolved.
}
1 change: 1 addition & 0 deletions web/app/themes/sage/config/view.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
'app' => App\View\Composers\App::class,
'postDataCollection' => App\View\Composers\PostDataCollectionComposer::class,
'postData' => App\View\Composers\PostDataComposer::class,
'navi' => App\View\Composers\NaviComposer::class,
],

/*
Expand Down
6 changes: 2 additions & 4 deletions web/app/themes/sage/resources/scripts/frontend/frontend.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ import A11yCookieYes from '@yardinternet/a11y-cookie-yes';
import {
A11yCards,
A11yFacetWP,
A11yMobileMenu,
Accordion,
BraveNavigationManager,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note voor mijzelf, dat de changes hiervan natuurlijk in een branch zitten in brave-frontend-kit. Vandaar dat ik het niet kon vinden toen ik global search deed.

https://github.com/yardinternet/brave-frontend-kit/tree/feat/brave-nav

DialogManager,
FocusStyle,
Navigation,
WebShareApi,
} from '@yardinternet/brave-frontend-kit';

Comment thread
YvetteNikolov marked this conversation as resolved.
Expand All @@ -20,10 +19,9 @@ window.addEventListener( 'DOMContentLoaded', () => {
new A11yCards();
A11yCookieYes.getInstance();
new A11yFacetWP();
new A11yMobileMenu();
new Accordion();
new BraveNavigationManager();
new DialogManager();
new FocusStyle();
new Navigation();
new WebShareApi();
} );
4 changes: 2 additions & 2 deletions web/app/themes/sage/resources/styles/base/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ p {
}

a {
@apply text-primary-600 underline;
@apply text-primary underline;

@variant hocus {
@apply text-primary-700;
@apply text-primary-600;
}

/* Hide links if they are empty. Easy fix for some Gutenberg and a11y issues. */
Expand Down
12 changes: 10 additions & 2 deletions web/app/themes/sage/resources/styles/base/variables.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,16 @@
/* Navigation */
--wp-admin-bar-height: var( --wp-admin--admin-bar--height, 0px );
--nav-bar-height: 80px;
--top-bar-height: 40px;
--combined-bar-height: var( --nav-bar-height ); /* Altered in top-bar.css */
--top-bar-height: 0px;
--combined-bar-height: calc(
var( --nav-bar-height ) + var( --top-bar-height )
);

@variant lg {
&:has( .top-bar ) {
--top-bar-height: 40px;
}
}

/* Container size */
--container-padding: 1rem;
Expand Down
53 changes: 0 additions & 53 deletions web/app/themes/sage/resources/styles/components/mobile-menu.css

This file was deleted.

73 changes: 0 additions & 73 deletions web/app/themes/sage/resources/styles/components/nav.css

This file was deleted.

21 changes: 0 additions & 21 deletions web/app/themes/sage/resources/styles/components/top-bar.css

This file was deleted.

3 changes: 0 additions & 3 deletions web/app/themes/sage/resources/styles/frontend.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
@import './components/facetwp';
@import './components/footer';
@import './components/gravity-forms';
@import './components/mobile-menu';
@import './components/nav';
@import './components/top-bar';

/* Elements */
@import './elements/forms';
Expand Down
Loading
Loading