chore: updated brave scaffold implementing wp-acf-registrar#95
Conversation
Rovasch
requested review from
FreakyWizard,
JasperS20,
ShunLuk,
SimonvanWijhe,
WybeBosch,
Yannicvanveen,
YvetteNikolov,
Copilot,
dtakken,
ictbeheer,
laravdiemen,
mvdhoek1 and
rivanuff
Composer package changes
|
There was a problem hiding this comment.
Pull request overview
Updates Brave’s scaffold/dependencies to support ACF registration via new Yard packages, and adds an initial Sage theme config entrypoint for ACF Registrar.
Changes:
- Add
yard/acf-registrarandyard/brave-acfdependencies for ACF field group/form/option page registration. - Bump
yard/brave-scaffoldfrom^2.0to^3.0. - Introduce
config/acf-registrar.phpand scaffold a placeholderapp/FieldGroups/directory.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/app/themes/sage/config/acf-registrar.php | Adds initial ACF Registrar configuration arrays (field groups, forms, option pages). |
| web/app/themes/sage/app/FieldGroups/.gitignore | Tracks the new FieldGroups directory via the repo’s .gitignore placeholder convention. |
| composer.json | Adds ACF-related packages and bumps the scaffold dependency major version. |
| composer.lock | Locks newly added ACF packages (and transitive deps) into the dependency graph. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward dependency additions and empty scaffold config.
Extended reasoning...
Overview
This PR adds two new first-party Composer dependencies ( and ), bumps the dev-only from to , updates accordingly, adds a gitignore to track the empty directory, and introduces a boilerplate config file with empty arrays.
Security risks
None. All new packages are from the same organization (), and the third-party transitive dependency () is a well-established MIT-licensed library. The config file contains no executable logic — only commented-out class references in empty arrays.
Level of scrutiny
Low. This is a scaffold update with no business logic changes. The major version bump is dev-only and does not affect production. The config file is purely declarative and empty by default.
Other factors
No bugs were found by the automated system, no prior reviews exist, and the changes follow established patterns in the codebase (other packages, Acorn service provider registration via ).
Rovasch
force-pushed
the
feat/wp-acf-registrar
branch
from
2dcbeab to
7118d7f
Compare
There was a problem hiding this comment.
LGTM — straightforward dependency addition and config scaffolding.
Extended reasoning...
Overview
This PR adds two new production Composer dependencies ( v2.0.0 and v1.1.0, plus their transitive dependency ), bumps the dev-only from to , updates the lock file accordingly, and adds a new empty config file at with placeholder arrays for , , and . A is also added to keep the directory tracked.
Security risks
None. The new packages are MIT-licensed libraries from the same organization that owns this project. The config file contains only static PHP arrays with commented-out placeholder values — no user input, no auth logic, no sensitive data.
Level of scrutiny
Low. This is a scaffold update and plugin wiring PR: adding established in-house packages and an empty configuration file. The major version bump is dev-only and already resolved in the lock file. No production logic is changed.
Other factors
Copilot left a style nit about array-bracket placement in (newline before vs. inline). This is cosmetic and does not affect correctness or security. No bugs were found by the automated bug hunter. No prior reviews from me exist on this PR.
There was a problem hiding this comment.
LGTM — straightforward dependency additions and config stub; the inline comment covers the style nit.
Extended reasoning...
Overview
This PR adds two new internal yard packages ( v2.0, v1.1) as production dependencies, bumps the dev-only from to , updates the lock file accordingly, adds a placeholder to keep the directory in git, and introduces as a registration config stub.
Security risks
None. The new dependencies are first-party yard packages with MIT licences. The config file is pure PHP returning an array of empty placeholder arrays — no executable logic, no user input, no auth surface.
Level of scrutiny
Low. The meaningful changes are adding two trusted internal packages and a nearly-empty config stub. The lock file update is mechanical. The only finding is a style nit (comment spacing and bracket placement) in commented-out placeholder code with zero runtime impact.
Other factors
Copilot already left an inline suggestion for the style fix; the bug hunter report echoes the same nit. Both are marked as cosmetic with no functional consequence. The inline comments will surface this to the author. Given the trivial nature of the sole finding and the straightforward intent of the PR, approval is appropriate.
Rovasch
force-pushed
the
feat/wp-acf-registrar
branch
from
4f97a87 to
508f983
Compare
This pull request updates dependencies and adds configuration for new plugins related to ACF (Advanced Custom Fields) registration in the project. The most significant changes are the addition of new packages for ACF management and the introduction of a configuration file for ACF Registrar.
Dependency updates and additions:
yard/acf-registrarandyard/brave-acfas new dependencies incomposer.jsonto support advanced custom fields registration and management.yard/brave-scaffolddependency from version^2.0to^3.0incomposer.jsonfor improved scaffolding features.Configuration:
web/app/themes/sage/config/acf-registrar.phpthat sets up arrays forfield_groups,forms, andoption_pagesto be used by the ACF Registrar package.