Skip to content

feat: add display-subtitle-toggle-control#142

Merged
laravdiemen merged 2 commits into
mainfrom
feat/display-subtitle-option
Apr 21, 2026
Merged

feat: add display-subtitle-toggle-control#142
laravdiemen merged 2 commits into
mainfrom
feat/display-subtitle-option

Conversation

@laravdiemen
Copy link
Copy Markdown
Contributor

Ik liep er tegenaan dat de klant op een specifieke plek de subtitel niet getoond wil hebben dus een toggle control lijkt mij sowieso wel een mooie oplossing.

image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Coverage report for commit: 75ed900
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 42.9%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ████████░░░░░░░░░░░░░░░ │ 14.3%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ████████░░░░░░░░░░░░░░░ │ 14.3%
 100% │ ████████████████░░░░░░░ │ 28.6%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 30.95% | Methods: 59.26%
FilesLinesMethodsBranches
src/Block
   Block.php--100.00%
   BlockAttributes.php92.86%93.75%100.00%
src/Casts
   IntCast.php50.00%-100.00%
src/Query
   PostQuery.php--100.00%
   QueryInterface.php100.00%100.00%100.00%
src
   QueryBlockServiceProvider.php--100.00%
src/Traits
   Helpers.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deze PR voegt een nieuwe block-attribute en inspector toggle toe om het tonen van een “subtitel” per block-configuratie aan/uit te zetten.

Changes:

  • Nieuwe displaySubtitle attribute toegevoegd aan block schema (assets/block.json + public/block.json).
  • Nieuwe inspector toggle control toegevoegd (DisplaySubtitleToggleControl) en opgenomen in de inspector configuratie.
  • Server-side BlockAttributes uitgebreid met displaySubtitle property + getter en bijbehorende tests.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/Block/BlockAttributesTest.php Voegt tests toe voor de nieuwe displaySubtitle() getter.
src/Block/BlockAttributes.php Voegt displaySubtitle property en getter toe aan het server-side attributes model.
public/index.asset.php Build artifact update (script dependencies/version hash).
public/block.json Registreert nieuwe displaySubtitle attribute in de distributie block.json.
package-lock.json Lockfile wijziging (dev-flag bij fsevents).
assets/config/inspector-config.js Maakt subtitle-toggle configureerbaar via inspector config.
assets/components/inspector.js Rendert de nieuwe subtitle toggle in de “Weergave” panel.
assets/components/display-controls/display-subtitle-toggle-control.js Nieuwe ToggleControl component voor displaySubtitle.
assets/block.json Registreert nieuwe displaySubtitle attribute in de source block.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Block/BlockAttributes.php Outdated
Comment thread tests/Block/BlockAttributesTest.php
Comment thread assets/block.json
Comment thread public/block.json
Copy link
Copy Markdown
Member

@SimonvanWijhe SimonvanWijhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even checken of alle attributes worden doorgegeven aan de backend, ongeacht de waarde (true or false) en in dat geval het advies van copilot overnemen.

@laravdiemen laravdiemen force-pushed the feat/display-subtitle-option branch from 12dcc2b to 75ed900 Compare April 21, 2026 11:33
@laravdiemen laravdiemen merged commit a5fc9bf into main Apr 21, 2026
5 checks passed
@laravdiemen laravdiemen deleted the feat/display-subtitle-option branch April 21, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants