feat: add display-subtitle-toggle-control#142
Merged
Conversation
|
Coverage report for commit: 75ed900 Summary - Lines: 30.95% | Methods: 59.26%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||
WybeBosch
approved these changes
Apr 16, 2026
Yannicvanveen
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Deze PR voegt een nieuwe block-attribute en inspector toggle toe om het tonen van een “subtitel” per block-configuratie aan/uit te zetten.
Changes:
- Nieuwe
displaySubtitleattribute toegevoegd aan block schema (assets/block.json+public/block.json). - Nieuwe inspector toggle control toegevoegd (
DisplaySubtitleToggleControl) en opgenomen in de inspector configuratie. - Server-side
BlockAttributesuitgebreid metdisplaySubtitleproperty + getter en bijbehorende tests.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Block/BlockAttributesTest.php | Voegt tests toe voor de nieuwe displaySubtitle() getter. |
| src/Block/BlockAttributes.php | Voegt displaySubtitle property en getter toe aan het server-side attributes model. |
| public/index.asset.php | Build artifact update (script dependencies/version hash). |
| public/block.json | Registreert nieuwe displaySubtitle attribute in de distributie block.json. |
| package-lock.json | Lockfile wijziging (dev-flag bij fsevents). |
| assets/config/inspector-config.js | Maakt subtitle-toggle configureerbaar via inspector config. |
| assets/components/inspector.js | Rendert de nieuwe subtitle toggle in de “Weergave” panel. |
| assets/components/display-controls/display-subtitle-toggle-control.js | Nieuwe ToggleControl component voor displaySubtitle. |
| assets/block.json | Registreert nieuwe displaySubtitle attribute in de source block.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SimonvanWijhe
approved these changes
Apr 21, 2026
12dcc2b to
75ed900
Compare
SimonvanWijhe
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ik liep er tegenaan dat de klant op een specifieke plek de subtitel niet getoond wil hebben dus een toggle control lijkt mij sowieso wel een mooie oplossing.