Skip to content

Updates to the latest TS patch#1205

Merged
arcanis merged 7 commits into
masterfrom
mael/ts-upgrade-3
Apr 19, 2020
Merged

Updates to the latest TS patch#1205
arcanis merged 7 commits into
masterfrom
mael/ts-upgrade-3

Conversation

@arcanis
Copy link
Copy Markdown
Member

@arcanis arcanis commented Apr 16, 2020

What's the problem this PR addresses?

typescript-eslint/typescript-eslint#1592

How did you fix it?

microsoft/TypeScript@bba19af

Test it with:

yarn set version from sources --branch 1205
yarn install

@regevbr
Copy link
Copy Markdown

regevbr commented Apr 16, 2020

So the patch doesn't really patch ts3.8 so the issue still persists.
Trying to install @next fails to apply the patch: Cannot apply hunk #1
@arcanis can you please advise?

@regevbr
Copy link
Copy Markdown

regevbr commented Apr 17, 2020

@arcanis is there something I can help with here?

@regevbr
Copy link
Copy Markdown

regevbr commented Apr 19, 2020

@arcanis I can confirm this now works well in windows with ts3.8! thanks!

@arcanis
Copy link
Copy Markdown
Member Author

arcanis commented Apr 19, 2020

Perfect, thanks! πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants