Revamps the constraints workflow#338
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff rearchitects the way we describe constraints in various ways:
The
gen_invalid_dependencyrule is no more 🎉, Yarn will instead infer the right action based on whether there's an ambiguity or not.The
gen_enforced_fieldcan now be autofixed (except when an ambiguity arises, same as with ambiguous dependencies).The field values in
gen_enforced_fieldwill be parsed into JSON if possible, or will be kept as string otherwise. It means that1.0will transform into"1", but"1.0"will stay"1.0".There's a known issue at the moment which is that objects will be compared against each other based on their JSON representation - which may cause issues if the objects are identical apart from their key ordering. PR welcome if you're affected by this 🙂
The
yarn constraints checkcommand is renamedyarn constraints, andyarn constraints fixis nowyarn constraints --fix(to match the ESLint syntax).Fixes #68, #122