Skip to content

Properly interpret double slashes in documentation#45

Merged
yazd merged 1 commit intoyazd:masterfrom
zatherz:slash-n-escape
Jul 28, 2017
Merged

Properly interpret double slashes in documentation#45
yazd merged 1 commit intoyazd:masterfrom
zatherz:slash-n-escape

Conversation

@zatherz
Copy link
Contributor

@zatherz zatherz commented Jul 12, 2017

\\ escapes were previously not included in the regex (despite having a mapping).
Older versions of DCR returned \n both for new lines and literal \ and n characters, which caused DKit to misbehave. For example, the description of writeln looked like this:

Equivalent to `write(args, '
')`.  Calling `writeln` without
arguments is valid and just prints a newline to the standard
output.

This was fixed in some version of DCR (it now returns \\n when it's a literal \n and still just a \n when it's a line break), but without this change, DKit shows the description of writeln as:

Equivalent to `write(args, '\\n')`.  Calling `writeln` without
arguments is valid and just prints a newline to the standard
output.

With this tiny fix, it now shows up as:

Equivalent to `write(args, '\n')`.  Calling `writeln` without
arguments is valid and just prints a newline to the standard
output.

@yazd yazd merged commit ed976c6 into yazd:master Jul 28, 2017
@yazd
Copy link
Owner

yazd commented Jul 28, 2017

As this looks independent, I'll merge it on its own. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants