Rewrited convert to Visitor Interface from ANTLR4 + fixed some types casts & error texts#12
Merged
1NepuNep1 merged 5 commits intoydb-platform:ydbfrom Sep 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the YDB parser to use ANTLR4's Visitor interface pattern instead of a custom convert method, while also adding several utility functions for collecting different types of operators and improving type safety.
- Replaced custom
convert()method with ANTLR4'sAccept()visitor pattern - Added type safety checks and error handling for visitor pattern conversions
- Introduced utility functions for collecting comparison, bitwise, addition, and equality operators
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/engine/ydb/utils.go | Refactored extractRoleSpec to use visitor pattern and added operator collection utility functions |
| internal/engine/ydb/parse.go | Updated statement parsing to use visitor pattern with proper type checking |
| go.mod | Updated yql-parsers dependency version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kprokopenko
approved these changes
Sep 22, 2025
asmyasnikov
pushed a commit
that referenced
this pull request
Dec 28, 2025
…casts & error texts (#12) * Rewrited ydb convert to Visitor Interface + validated type casts and error texts
asmyasnikov
pushed a commit
that referenced
this pull request
Jan 10, 2026
…casts & error texts (#12) * Rewrited ydb convert to Visitor Interface + validated type casts and error texts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to (#8)