Ydb-go-sdk codegen: Containers support in ydb.ParamsBuilder()#15
Merged
1NepuNep1 merged 5 commits intoydb-platform:ydbfrom Oct 9, 2025
Merged
Ydb-go-sdk codegen: Containers support in ydb.ParamsBuilder()#151NepuNep1 merged 5 commits intoydb-platform:ydbfrom
1NepuNep1 merged 5 commits intoydb-platform:ydbfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds list support for YDB engine in sqlc, extending parameter handling and type conversion capabilities.
- Enhanced YDB parameter handling for list/array types with new builder methods and template logic
- Added type conversion support for YDB composite types (list, tuple, struct, variant)
- Refactored code generation to handle complex container types that require manual parameter passing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/sql/rewrite/parameters.go | Adds YDB-specific parameter replacement logic |
| internal/engine/ydb/convert.go | Implements YDB type conversion for lists, tuples, and other composite types |
| internal/codegen/golang/ydb_type.go | Updates array type handling for YDB columns |
| internal/codegen/golang/templates/ydb-go-sdk/queryCode.tmpl | Modifies templates to support complex container parameters |
| internal/codegen/golang/query.go | Adds new methods for YDB parameter building and complex type detection |
| examples/authors/ydb/query.sql.go | Shows updated generated code with new parameter builder pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1NepuNep1
changed the title
1NepuNep1
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kprokopenko
approved these changes
Oct 8, 2025
asmyasnikov
pushed a commit
that referenced
this pull request
Dec 28, 2025
* Added Arrays support + rewrites some internal logic to handle sqlc.arg/narg/slice in ydb
* Supported containertype named parameters
* Rewrited params to handle compex types and comment if type is interface{}
asmyasnikov
pushed a commit
that referenced
this pull request
Jan 10, 2026
* Added Arrays support + rewrites some internal logic to handle sqlc.arg/narg/slice in ydb
* Supported containertype named parameters
* Rewrited params to handle compex types and comment if type is interface{}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4