Conversation
Updated readme
Fixes spawning bower and npm on Windows systems.
Fixes fonts not being copied into build folder
|
Use the AngularJS commit message guidelines. Not sure I like this solution though. Better to use an argument or an option than hacking the |
|
Will look at the guidelines as soon as they are reachable. Can you perhaps add that link to the contributing docs here? First time I've seen reference to them from this project. Also, will research the options route. Not familiar with where those get set (assuming from yo itself), will investigate and update. |
|
So the only thing with using just the options is that there doesn't appear to be a way to configure these so you do not have to type them in every time. This would be a project setting that wouldn't change once configured and would be annoying to have to type the same value every time. Any thoughts? |
feat: Allow for configurable index file name with command line option
Add a check for the command line options (--indexFile) to be able determine
where script files will be appended to.
Example:
yo angular:controller main --indexFile=other.html
|
@btford, you feel this is needed? |
|
Yeah, I've needed this occasionally too to make Yeoman play nice with the server. I'm not sure if this is the best solution though. Let me think on it a bit. |
|
@nick-pww can you fix the merge conflict? |
|
thats a lot of commits for this change. would it be possible to do a clean branch off master, make the changes and then submit that as a pr? i have no say in the project but it would make a cleaner history |
|
No need to create a new PR. Just force push to this one. |
8 participants
This allows for the index.html page name to be configurable.