Skip to content

Refactoring name generating functions in TH #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parsonsmatt merged 29 commits into from
Apr 20, 2021
Merged

Refactoring name generating functions in TH #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
25e5361
Extract name function for ToJSON instance
danbroooks Mar 24, 2021
a3e3448
Extract mkRecName
danbroooks Mar 24, 2021
c51c721
Extract `mkEntityDefDeriveNames`
danbroooks Mar 24, 2021
3cc9b8d
Extract mkEntityDefName* functions
danbroooks Mar 24, 2021
4ee4c53
Move sumConstrName
danbroooks Mar 24, 2021
39859a1
Extract mkConstraintName
danbroooks Mar 24, 2021
44f0063
Extract `mkEntityNameHS*` functions
danbroooks Mar 24, 2021
7ba298e
Refactor using new functions
danbroooks Mar 24, 2021
ee08897
Absorb more functions
danbroooks Mar 24, 2021
e943f2b
Another extraction
danbroooks Mar 24, 2021
5811d15
Move already extracted functions for key names
danbroooks Mar 24, 2021
a14202c
Refactor to reuse functions
danbroooks Mar 24, 2021
22970ef
More reuse
danbroooks Mar 24, 2021
955fb6c
More reuse
danbroooks Mar 24, 2021
09a481b
Move filterConName
danbroooks Mar 24, 2021
3cfeab6
Consistent unpack
danbroooks Mar 24, 2021
855008d
Dont shaddow name
danbroooks Mar 24, 2021
6b95316
Extracting helpers
danbroooks Mar 24, 2021
e4ff688
Change mkRecName to take EntityDef
danbroooks Mar 29, 2021
f690488
Move entity derives logic out into name creation function
danbroooks Mar 29, 2021
c6fea20
DRY up `backendT`
danbroooks Mar 29, 2021
e298145
Rename function
danbroooks Mar 29, 2021
0d3bfca
Refactor cols value
danbroooks Mar 29, 2021
808d457
More renaming
danbroooks Mar 29, 2021
399e7f6
More shifting around
danbroooks Mar 29, 2021
f333063
Merge branch 'master' into th-name-fns
danbroooks Apr 20, 2021
d0a41bb
Update changelog
danbroooks Apr 20, 2021
d989585
Flip changelog formatting
danbroooks Apr 20, 2021
49eebea
Tweaking changlog format again
danbroooks Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion persistent/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

## 2.12.1.0

* [#1226](https://github.com/yesodweb/persistent/pull/1226)
* [#1218](https://github.com/yesodweb/persistent/pull/1218)
* Refactoring name generating functions in TH
* [#1226](https://github.com/yesodweb/persistent/pull/1226)
* Expose the `filterClause` and `filterClauseWithValues` functions to support
the `upsertWhere` functionality in `persistent-postgresql`.

Expand Down
Loading