Skip to content

Deprecate mpsGeneric #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parsonsmatt merged 2 commits into from
Apr 26, 2021
Merged

Deprecate mpsGeneric #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5a2ea
Deprecate mpsGeneric
parsonsmatt Apr 23, 2021
b5a09f3
merge, changelog
parsonsmatt Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions persistent/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@
* Add the `runSqlCommand` function for running arbitrary SQL during
migrations.
* Add `migrateModels` function for a TH-free migration facility.
* [#1250](https://github.com/yesodweb/persistent/pull/1250)
* The `mpsGeneric` function has been deprecated. If you need this
functionality, please comment with your needs on the GitHub issue tracker.
We may un-deprecate it, or we may provide a new and better means of
facilitating a solution to your problem.

## 2.12.1.1

Expand Down
3 changes: 3 additions & 0 deletions persistent/Database/Persist/TH.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,9 @@ data MkPersistSettings = MkPersistSettings
-- @since 2.13.0.0
}


{-# DEPRECATED mpsGeneric "The mpsGeneric function adds a considerable amount of overhead and complexity to the library without bringing significant benefit. We would like to remove it. If you require this feature, please comment on the linked GitHub issue, and we'll either keep it around, or we can figure out a nicer way to solve your problem.\n\n Github: https://github.com/yesodweb/persistent/issues/1204" #-}

-- | Set the 'ImplicitIdDef' in the given 'MkPersistSettings'. The default
-- value is 'autoIncrementingInteger'.
--
Expand Down