Fix mongo#1286
Conversation
| embeddedVal pv | ||
| ) | ||
| $ filter (\(_, pv) -> isNull pv) | ||
| $ filter (\(_, pv) -> not $ isNull pv) |
There was a problem hiding this comment.
The major fix was this! At least for our needs this was the only thing that really broke anything.
There was a problem hiding this comment.
Wow. I'm really surprised that worked?
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Well done! I'm surprised and impressed 😂
Can you update the persistent-mongoDB.cabal file to be the new version? I can merge and release it then.
Would you be willing to accept maintainership responsibilities for persistent-mongoDB? I'll add you as a user on Hackage and give you access to the repository.
Thanks!
| embeddedVal pv | ||
| ) | ||
| $ filter (\(_, pv) -> isNull pv) | ||
| $ filter (\(_, pv) -> not $ isNull pv) |
There was a problem hiding this comment.
Wow. I'm really surprised that worked?
Sounds good. I'll have to maintain it for the time being while our team continues to use mongodb! |
|
What's a Hackage username I can add? |
|
I have an upload account with aschmois |
|
No problem from my side. I just added you on Hackage for persistent-mongoDB and as a repo writer. Thank you! |
|
@aschmois Want to do the honors (sqash+merge+release)? |
3 participants
Before submitting your PR, check that you've:
stylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the ChangelogCloses #1284
Since embedded fields have been removed there are some sacrifices we had to make but the majority of the features should still be working. Embedded fields will be set as null and they will be unordered when retrieved.