Conversation
JuArce
approved these changes
Oct 14, 2024
Contributor
|
Works on my machine |
PatStiles
approved these changes
Oct 14, 2024
…ide-last_processed_batch_filepath-in-config-file
uri-99
suggested changes
Oct 14, 2024
Contributor
uri-99
left a comment
uri-99
left a comment
There was a problem hiding this comment.
It should also fail if the folder of the file is non-existent. This is because Operator will fail to create the file if the folder given does not exist.
Member
Author
Updated! |
uri-99
suggested changes
Oct 14, 2024
Contributor
uri-99
left a comment
uri-99
left a comment
There was a problem hiding this comment.
new constraint doesnt allow creation of file. It should be able to create a file, but only on an existing directory.
uri-99
approved these changes
Oct 14, 2024
uri-99
deleted the
1209-dont-start-operator-if-it-hasnt-provide-last_processed_batch_filepath-in-config-file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If
last_processed_batch_filepathis not provided on the operator config, then don't start the program. This is to make sure operator owners don't forget to pass this new field. Alternatively, we could create a default file but I am not sure about how that could go.Testing
Remove the
last_processed_batch_filepathfrom the operator config and you should see an err indicating the missing field.Closes #1209