Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
254 commits
Select commit Hold shift + click to select a range
d23cf00
Remove LDE spilling, reuse reconstruct_round1 for Rounds 2-4
gabrielbosio Mar 26, 2026
8f26413
Remove no-op late trace re-spill
gabrielbosio Mar 26, 2026
e7e5769
Remove Merkle tree node spilling
gabrielbosio Mar 26, 2026
fe5776f
Revert "Remove Merkle tree node spilling"
gabrielbosio Mar 27, 2026
aa24927
Disk-spill composition poly and FRI layer Merkle trees
gabrielbosio Mar 27, 2026
f2654f7
Disk-spill FRI layer evaluations and composition poly evaluations
gabrielbosio Mar 27, 2026
c8eeb7b
Lazy-allocate pool buffers instead of pre-allocating at max size
gabrielbosio Mar 27, 2026
1a7ebbc
Bring back LDE spilling for Rounds 2-4 to reduce peak pool memory
gabrielbosio Mar 27, 2026
94dcef1
Free pool buffers between phases to reduce peak memory
gabrielbosio Mar 27, 2026
23794bb
Spill LDE and free pool inside parallel closure to reduce peak memory
gabrielbosio Mar 27, 2026
a49e275
Use k_commit=1 for Phase A/C to avoid multiple large pools alive simu…
gabrielbosio Mar 27, 2026
098833c
Drop trace mmap pages from page cache after extracting into pool buffers
gabrielbosio Mar 27, 2026
4316726
Restore main_commits_elapsed timing for instruments feature
gabrielbosio Mar 27, 2026
adf2dab
Add per-phase heap profiling to instruments
gabrielbosio Mar 27, 2026
567a235
Pre-allocate pool to max_lde_size and keep capacity between tables
gabrielbosio Mar 27, 2026
b566cc0
Spill aux traces to disk immediately after building
gabrielbosio Mar 28, 2026
bcdc7da
Fix clippy unused_mut warnings when disk-spill is disabled
gabrielbosio Mar 28, 2026
5bb8c05
Add 16M-128M sizes to bench_heap_profile.sh
gabrielbosio Mar 30, 2026
8d0d6a7
Default k_commit=4 for disk-spill Phase A/C to balance memory and par…
gabrielbosio Mar 31, 2026
e572b46
Revert "Default k_commit=4 for disk-spill Phase A/C to balance memory…
gabrielbosio Mar 31, 2026
f3ca018
Skip composition poly and FRI spills in Rounds 2-4 to reduce I/O over…
gabrielbosio Apr 1, 2026
ee323bc
Merge remote-tracking branch 'origin/main' into feat/disk-spill-v2-pa…
gabrielbosio Apr 1, 2026
75537a8
Remove max-rows CLI arg
gabrielbosio Apr 1, 2026
abf8014
Remove heap profiling infrastructure (moved to separate PR)
gabrielbosio Apr 1, 2026
a2d0e4e
Use prover::prove for default blowup path
gabrielbosio Apr 1, 2026
55cb1a3
Simplify MmapNodeBacking doc comment
gabrielbosio Apr 1, 2026
e465b38
Clarify clone assert message for spilled MerkleTree
gabrielbosio Apr 1, 2026
c4326e6
Disable Clone for MerkleTree and FriLayer when disk-spill is enabled
gabrielbosio Apr 1, 2026
fdb37d2
Simplify unsafe safety comment in node_get
gabrielbosio Apr 1, 2026
f0b0d5e
Add compile-time alignment assert for mmap node access
gabrielbosio Apr 1, 2026
122c986
Simplify spill_nodes_to_disk doc comment
gabrielbosio Apr 1, 2026
461e45d
Fix safety comment for node byte cast
gabrielbosio Apr 1, 2026
ff63f9c
Simplify safety comment
gabrielbosio Apr 1, 2026
bdba457
Explain why tempfile is exclusively owned in safety comment
gabrielbosio Apr 1, 2026
3c88c30
Document _file field in MmapNodeBacking
gabrielbosio Apr 1, 2026
78ceae2
Document _file field, remove unused _len from EvalMmapBacking
gabrielbosio Apr 1, 2026
63f26bd
Document EvalMmapBacking struct
gabrielbosio Apr 1, 2026
eb5164d
Add safety comment to get_evaluation mmap access
gabrielbosio Apr 1, 2026
a244ec8
Add safety comments to spill_evaluation_to_disk
gabrielbosio Apr 1, 2026
9bc5da6
Inline FriLayer::new back into push
gabrielbosio Apr 1, 2026
6e0d5e9
Document Round2EvalMmap struct
gabrielbosio Apr 1, 2026
04b7e3e
Add safety comment to get_composition_eval mmap access
gabrielbosio Apr 1, 2026
6df4e40
Add safety comments to spill_evaluations_to_disk
gabrielbosio Apr 1, 2026
6152c91
Add comments explaining advise_drop_cache calls
gabrielbosio Apr 1, 2026
abbcbe1
Remove leftover spill comments
gabrielbosio Apr 1, 2026
5e22753
Remove unnecessary &mut on round_2_result
gabrielbosio Apr 1, 2026
5fbbe1c
Simplify trace spill comment
gabrielbosio Apr 1, 2026
28cb672
Clean up k_commit and pool allocation comments
gabrielbosio Apr 1, 2026
b162db0
Remove leftover empty snap calls
gabrielbosio Apr 1, 2026
6a7e22f
Simplify spilled_ldes comment
gabrielbosio Apr 1, 2026
852b150
Simplify Rounds 2-4 section comment
gabrielbosio Apr 1, 2026
b91a9e8
Remove 'original flow' from comment
gabrielbosio Apr 1, 2026
27b5986
Remove end-of-block comment
gabrielbosio Apr 1, 2026
c1ad3ee
Clarify why TableMmapBacking implements Clone
gabrielbosio Apr 1, 2026
44a52e6
Remove unnecessary Default impl for TableMmapBacking
gabrielbosio Apr 1, 2026
a825766
Fix safety comment in get_row
gabrielbosio Apr 1, 2026
9001507
Remove obvious comment in extract_columns_into
gabrielbosio Apr 1, 2026
dac2b12
Fix mmap safety comment in spill_to_disk
gabrielbosio Apr 1, 2026
a9e7ca7
Document TableMmapBacking fields
gabrielbosio Apr 1, 2026
6fb5a02
Add safety comment and fix doc for advise_drop_cache
gabrielbosio Apr 1, 2026
431af17
Shorten advise_drop_cache safety comment
gabrielbosio Apr 1, 2026
5128e86
Restore original halt timestamp comment
gabrielbosio Apr 1, 2026
b6b3283
Restore Phase 3 comment in prove_with_options
gabrielbosio Apr 1, 2026
c3cae82
Simplify spill_main_to_disk doc
gabrielbosio Apr 1, 2026
6441b46
Simplify MmapBacking doc and document _file fields
gabrielbosio Apr 1, 2026
fcb8a35
Fix safety comments in get_main and get_aux
gabrielbosio Apr 1, 2026
0a2a9bf
Inline safety comment for get_aux
gabrielbosio Apr 1, 2026
853c0fa
Simplify spill_main_from_pool doc
gabrielbosio Apr 1, 2026
3a34984
Simplify write_pool_columns_to_mmap doc
gabrielbosio Apr 1, 2026
8150c29
Fix mmap safety comment in write_pool_columns_to_mmap
gabrielbosio Apr 1, 2026
2d76233
Fix generic type name in safety comment
gabrielbosio Apr 1, 2026
39647bf
Fix formatting
gabrielbosio Apr 1, 2026
535fa5a
Add comment for TLS instruments pattern
gabrielbosio Apr 1, 2026
4ba225c
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 8, 2026
63d1c05
Extract round1_from_lde to deduplicate disk-spill Round1 construction
gabrielbosio Apr 8, 2026
7ec6dc6
Fix precomputed tree spill error propagation, remove dead spill code
gabrielbosio Apr 8, 2026
289cb83
Remove trivial FriLayer::get_evaluation wrapper
gabrielbosio Apr 8, 2026
914b632
Remove trivial Round2 wrapper methods
gabrielbosio Apr 8, 2026
641cde6
Merge main, resolve memw_register trace conflict
gabrielbosio Apr 9, 2026
ad3b6b4
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 13, 2026
3aac114
Document repr(transparent) requirement for mmap casts
gabrielbosio Apr 14, 2026
059292c
Assert mmap bounds in release builds
gabrielbosio Apr 14, 2026
156ad8a
Close mmap-backing file descriptors after creation
gabrielbosio Apr 14, 2026
563cca2
Check spill byte counts for overflow
gabrielbosio Apr 14, 2026
3280720
Validate elem_size matches size_of in write_pool_columns_to_mmap
gabrielbosio Apr 14, 2026
b357c8b
Compare tables by field-element equality
gabrielbosio Apr 14, 2026
5e8a8ff
Propagate aux trace spill errors through ProvingError
gabrielbosio Apr 14, 2026
52d431d
Advise page cache drop for aux mmap after extract
gabrielbosio Apr 14, 2026
fca8dba
Run disk-spill tests in CI
gabrielbosio Apr 14, 2026
ced02ae
Merge main, rename Round1Metadata to Round1Commitments
gabrielbosio Apr 15, 2026
11e21d7
Merge main into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 20, 2026
d43b786
Merge remote-tracking branch 'origin/main' into feat/disk-spill-v2-pa…
gabrielbosio Apr 20, 2026
eb76d40
Cache LDE in RAM instead of spilling to disk
gabrielbosio Apr 20, 2026
f6d32ca
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 20, 2026
9f99503
Fix non-parallel disk-spill build by declaring spill_iter mut
gabrielbosio Apr 20, 2026
0485cb6
Drop trace_lde from TableSubOps
gabrielbosio Apr 20, 2026
73fd963
Add fib_iterative_24M program
gabrielbosio Apr 20, 2026
ba2903e
Remove fib_iterative_32M/64M/128M programs
gabrielbosio Apr 20, 2026
d768316
Revert unrelated fib_iterative_2M tweak
gabrielbosio Apr 21, 2026
97526a5
Tighten FieldElement repr invariant doc
gabrielbosio Apr 21, 2026
40c86c7
Harden disk-spill Table safety and portability
gabrielbosio Apr 21, 2026
d61ed60
Add DiskSpill proving error variant
gabrielbosio Apr 21, 2026
fb5c370
Match instruments label to function name
gabrielbosio Apr 21, 2026
f90c5cb
Drop heading from FieldElement doc
gabrielbosio Apr 21, 2026
7df58d7
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 21, 2026
494e4e9
Reword FieldElement doc without metaphor
gabrielbosio Apr 21, 2026
1c100d2
Merge branch 'feat/disk-spill-v2-parallel-r2' of github.com:yetanothe…
gabrielbosio Apr 21, 2026
dc5a63a
Drop 'silently' from FieldElement doc
gabrielbosio Apr 21, 2026
d4b548b
Make disk-spill opt-in for CLI
gabrielbosio Apr 21, 2026
93bb2ad
Add clippy pass for disk-spill feature
gabrielbosio Apr 21, 2026
a249833
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 21, 2026
2a58932
Fsync spill files before mmap
gabrielbosio Apr 21, 2026
4ddd348
Merge branch 'feat/disk-spill-v2-parallel-r2' of github.com:yetanothe…
gabrielbosio Apr 21, 2026
99b62d1
Spill via MmapMut instead of write
gabrielbosio Apr 22, 2026
7d9a67a
Merge remote-tracking branch 'origin/main' into feat/disk-spill-v2-pa…
gabrielbosio Apr 22, 2026
e462b29
Make disk-spill default for CLI
gabrielbosio Apr 22, 2026
bbf812c
Spill memw_aligned and memw_register tables too
gabrielbosio Apr 24, 2026
8b161a6
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 24, 2026
da9c693
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 30, 2026
de76ce7
Disk spilling based on heap usage (#557)
gabrielbosio Apr 30, 2026
3dce783
Remove dead extract_columns_into
gabrielbosio Apr 30, 2026
a626c31
Use checked_mul in spill_nodes_to_disk
gabrielbosio Apr 30, 2026
9a4b1fc
Require Copy on BaseType for spill_to_disk
gabrielbosio Apr 30, 2026
70634b9
Materialize spilled data when serializing
gabrielbosio Apr 30, 2026
82cd101
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio Apr 30, 2026
2881cff
Gate wasm32 compile_error on disk-spill
gabrielbosio Apr 30, 2026
2e22b5b
Assert mmap-fitting alignment instead of layout tautology
gabrielbosio Apr 30, 2026
9c009f1
Assert page_size is power of two
gabrielbosio Apr 30, 2026
210a895
Drop stale percentage from max_ram_bytes doc
gabrielbosio Apr 30, 2026
6507fa0
Tighten count_table_lengths comment
gabrielbosio Apr 30, 2026
cfa6eb2
Warn on Ram pick that may exceed cgroup limit
gabrielbosio Apr 30, 2026
a785986
Reserve spill file blocks via posix_fallocate
gabrielbosio Apr 30, 2026
b6abf7e
Share reserve_file_blocks between spill paths
gabrielbosio Apr 30, 2026
1fa7652
Harden posix_fallocate against overflow and EOPNOTSUPP
gabrielbosio May 1, 2026
d1ab8c2
Compute decode rows analytically in count_table_lengths
gabrielbosio May 1, 2026
dec6164
Build calibration CLI with disk-spill feature
gabrielbosio May 1, 2026
382dd9e
Replace Copy bound with SpillSafe marker on spill paths
gabrielbosio May 1, 2026
fb5a8da
Guard Table::set against spilled tables
gabrielbosio May 2, 2026
922b5d7
Document SIGBUS risk on non-Linux temp filesystems
gabrielbosio May 2, 2026
2df8244
Spill fixed and page tables in build_traces
gabrielbosio May 3, 2026
8be6ba2
Suppress unused_mut warning without disk-spill
gabrielbosio May 4, 2026
90c9033
Skip commit op materialization in count_table_lengths
gabrielbosio May 4, 2026
78b6bd6
Remove unused spill_all_main_to_disk
gabrielbosio May 4, 2026
8d00881
Make spill_nodes_to_disk idempotency check explicit
gabrielbosio May 4, 2026
277ebda
Trim SpillSafe doc to layout invariants
gabrielbosio May 4, 2026
d5512af
Loosen merkle node alignment to mmap page size
gabrielbosio May 4, 2026
7ade601
Drop unnecessary mmap flush before make_read_only
gabrielbosio May 4, 2026
ce24fb8
Assert max_rows is positive in padded_chunked_rows
gabrielbosio May 4, 2026
7ab6751
Fail fast when posix_fallocate is unsupported
gabrielbosio May 4, 2026
ae6a11f
Tighten reserve_file_blocks doc
gabrielbosio May 4, 2026
fe48952
Stream spilled MerkleTree nodes during serialize
gabrielbosio May 4, 2026
d7de626
Document MerkleTree disk-spill Serialize impl
gabrielbosio May 4, 2026
54b4968
Drop #[inline] from MerkleTree node accessors
gabrielbosio May 4, 2026
c5af906
Tighten MmapNodesSeq doc comment
gabrielbosio May 4, 2026
dce4537
Rephrase node_get SAFETY comment
gabrielbosio May 4, 2026
b47427f
Refresh stale comments in spill_nodes_to_disk and spill_safe
gabrielbosio May 4, 2026
a31ebed
Stream spilled Table data through serialize_seq
gabrielbosio May 4, 2026
d37d3e2
Make Table::set spill guard a hard assert
gabrielbosio May 4, 2026
d05affc
Drop redundant node_size from MmapNodeBacking
gabrielbosio May 4, 2026
86992f4
Account for halt padding in peak_bytes
gabrielbosio May 4, 2026
6957e68
Drop stale max_ram_bytes advice from default-Disk warning
gabrielbosio May 4, 2026
020781e
Replace dead unwrap_or in cgroup-near-OOM warning
gabrielbosio May 4, 2026
83c8da9
Document why available.unwrap() is safe
gabrielbosio May 5, 2026
3af6a2b
Note advise_drop_cache reliability per platform
gabrielbosio May 5, 2026
097361a
Extract spill_slice_to_mmap helper into mmap_util
gabrielbosio May 5, 2026
c7029bd
Make padded_chunked_rows zero-row guard a hard assert
gabrielbosio May 5, 2026
4e101e1
Note tmpfs caveat for spill files
gabrielbosio May 5, 2026
470014d
Test count_table_lengths against built Traces
gabrielbosio May 5, 2026
520d60c
Trim spill_slice_to_mmap doc comment
gabrielbosio May 5, 2026
f0d110e
Gate aux_merkle on aux_cols > 0
gabrielbosio May 5, 2026
26adc43
Revert halt_rows estimate to actual height
gabrielbosio May 5, 2026
a7ccd39
Raise auto-Disk warning threshold to 75%
gabrielbosio May 5, 2026
404fb7a
Make reserve_file_blocks private
gabrielbosio May 5, 2026
330567e
Reorder mmap_util to lead with public API
gabrielbosio May 5, 2026
a265599
Restore owned buffers wording in coset_lde_full_expand doc
gabrielbosio May 5, 2026
8581b1e
Update FieldElement repr soundness doc to reference SpillSafe
gabrielbosio May 5, 2026
517734f
Restore derived PartialEq for non-spill Table builds
gabrielbosio May 5, 2026
5fd4ffe
Tighten SpillSafe module doc comment
gabrielbosio May 5, 2026
6a3d8d8
Feature-gate ProofOptions::max_ram_bytes behind disk-spill
gabrielbosio May 6, 2026
c41d972
Tighten wasm32 disk-spill compile_error comment
gabrielbosio May 6, 2026
d5963b0
Drop typically from DiskSpill error doc
gabrielbosio May 6, 2026
a70a21a
Drop redundant advise_drop_cache inline comment
gabrielbosio May 6, 2026
73a1493
Merge multi_prove and multi_prove_with_mode into one entry point
gabrielbosio May 6, 2026
4a3acbf
Restore Domain/LdeTwiddles dedup rationale in multi_prove
gabrielbosio May 6, 2026
9565c2f
Restore domain_cache drop rationale comment
gabrielbosio May 6, 2026
bf9ed5f
Move multi_prove_ram from trait method to test_utils
gabrielbosio May 6, 2026
c9cd42d
Use multi_prove_ram via use statement at call sites
gabrielbosio May 6, 2026
dbc4888
Trim TableMmapBacking doc comment
gabrielbosio May 6, 2026
df991df
Make TableMmapBacking and mmap_backing private
gabrielbosio May 6, 2026
360c504
Tighten Table Clone impl doc comment
gabrielbosio May 6, 2026
ca38e82
Drop streaming-serialize wrapper doc comments
gabrielbosio May 6, 2026
69360a8
Drop Table PartialEq doc comment
gabrielbosio May 6, 2026
57dbdb2
Tighten get_row/get assert comment
gabrielbosio May 6, 2026
19f8d3d
Restore T1 transpose rationale in extract_columns doc
gabrielbosio May 6, 2026
2645033
Drop unnecessary inline on Table::get
gabrielbosio May 6, 2026
4aa761b
Drop is_spilled accessor, inline mmap_backing checks
gabrielbosio May 6, 2026
03c288f
Use intra-doc links in spill_to_disk doc comment
gabrielbosio May 6, 2026
b6f80e6
Use prelude size_of and import spill_slice_to_mmap
gabrielbosio May 6, 2026
8d36228
Add use statements in mmap_util to drop fully-qualified paths
gabrielbosio May 6, 2026
0288653
Drop redundant doc comments on disk_spill_tests
gabrielbosio May 6, 2026
15e5d07
Drop redundant Test convenience suffix on multi_prove_ram doc
gabrielbosio May 6, 2026
8c48b93
Drop multi_prove_ram doc comment
gabrielbosio May 6, 2026
ad70ae9
Drop disk-spill dep comment in stark Cargo.toml
gabrielbosio May 6, 2026
2a4d415
Rephrase unique_page_count doc comment
gabrielbosio May 6, 2026
78cec6a
Import HashSet in trace_builder
gabrielbosio May 6, 2026
44ecac5
Trim padded_chunked_rows doc comment
gabrielbosio May 6, 2026
8394311
Drop redundant TableLengths field doc comments
gabrielbosio May 6, 2026
f3c5bfd
Drop unused_mut rationale comment, gate HashSet import
gabrielbosio May 6, 2026
312b670
Drop stale multi_prove_inner reference in trace_builder spill comment
gabrielbosio May 6, 2026
7e008f1
Rephrase count_table_lengths doc comment
gabrielbosio May 6, 2026
9b30bfd
Trim over-specific comments in count_table_lengths
gabrielbosio May 6, 2026
78a92da
Drop redundant ECALL Commit comment
gabrielbosio May 6, 2026
da8fde2
Use building instead of materializing in commit count comment
gabrielbosio May 6, 2026
c320339
Restore ECALL Commit block-marker comment
gabrielbosio May 6, 2026
56437fc
Merge from_elf_and_logs variants into one entry point
gabrielbosio May 6, 2026
19c7cde
Trim drift test module doc comment
gabrielbosio May 6, 2026
90b4283
Trim disk_spill_tests module doc comment
gabrielbosio May 6, 2026
16bc3e3
Drop redundant doc comments on disk_spill tests
gabrielbosio May 6, 2026
77338e9
Use all_instructions_64 ELF for chunking disk-spill tests
gabrielbosio May 6, 2026
152d58d
Use fib_iterative_372k in disk-spill scale test
gabrielbosio May 6, 2026
2f349b0
Trim peak_bytes_calibration_tests module doc
gabrielbosio May 6, 2026
ae632e7
Replace RSS calibration with jemalloc heap-only check
gabrielbosio May 6, 2026
5c517cc
Trim peak_bytes_calibration_tests module doc
gabrielbosio May 6, 2026
d2f9be6
Run all prover tests under disk-spill feature in CI
gabrielbosio May 6, 2026
1230403
Extract AirTracePair alias to silence type_complexity
gabrielbosio May 6, 2026
be01419
Trim comments in prove_with_options_and_inputs storage mode block
gabrielbosio May 6, 2026
603feb9
Import count_table_lengths in lib.rs
gabrielbosio May 6, 2026
178b166
Import table_parallelism in lib.rs
gabrielbosio May 6, 2026
3059f2a
Drop confusing Phase 5 comment before from_elf_and_logs
gabrielbosio May 6, 2026
4693226
Inline multi_prove arguments
gabrielbosio May 6, 2026
df11ef4
Replace ProofOptions::max_ram_bytes with FORCE_DISK_SPILL env var
gabrielbosio May 6, 2026
9116dd2
Drop env_logger init from disk_spill 372k test
gabrielbosio May 6, 2026
c5a41dc
Reword calibrate_threshold doc to not leak internals
gabrielbosio May 6, 2026
e9f0329
Move peak_bytes calibration to integration test
gabrielbosio May 7, 2026
dbf075c
Compile Rust ELFs in Disk-spill tests job
gabrielbosio May 7, 2026
6c29ed7
Use checked_next_power_of_two for commit_count
gabrielbosio May 7, 2026
ac9cfe8
Replace fib_iterative_24M with 32M
gabrielbosio May 7, 2026
12909f1
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio May 13, 2026
8d33a32
Use traces_from_elf_and_logs_ram in keccak tests
gabrielbosio May 13, 2026
2176b85
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio May 15, 2026
d78e0c0
Merge branch 'main' into feat/disk-spill-v2-parallel-r2
gabrielbosio May 18, 2026
7da645a
Use full bitwise for direct-indexing and security tests
gabrielbosio May 18, 2026
dbb012a
Filter prover CI step to disk-spill tests
gabrielbosio May 18, 2026
20cd6e8
Merge remote-tracking branch 'origin/main' into feat/disk-spill-v2-pa…
gabrielbosio May 18, 2026
494bc48
Move output assert before drop(result)
gabrielbosio May 18, 2026
7588c74
Merge disk-spill prove and serde roundtrip tests
gabrielbosio May 18, 2026
369bd94
Drop fib_iterative_372k disk-spill test
gabrielbosio May 18, 2026
a54ce1c
Merge origin/main into feat/disk-spill-v2-parallel-r2
gabrielbosio May 19, 2026
80348b0
Set FORCE_DISK_SPILL in CI, drop RAII guard and --test-threads=1
gabrielbosio May 19, 2026
fafc9a5
Add make test-disk-spill target
gabrielbosio May 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 65 additions & 1 deletion .github/workflows/pr_main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,18 @@ jobs:
test:
name: Test
if: always()
needs: [test-executor, test-prover]
needs: [test-executor, test-prover, test-disk-spill]
runs-on: ubuntu-latest
steps:
- name: Check results
run: |
executor="${{ needs.test-executor.result }}"
prover="${{ needs.test-prover.result }}"
disk_spill="${{ needs.test-disk-spill.result }}"

echo "test-executor: $executor"
echo "test-prover: $prover"
echo "test-disk-spill: $disk_spill"

# Allow "success" or "skipped" (skipped on merge queue pushes)
if [[ "$executor" != "success" && "$executor" != "skipped" ]]; then
Expand All @@ -123,6 +125,68 @@ jobs:
if [[ "$prover" != "success" && "$prover" != "skipped" ]]; then
exit 1
fi
if [[ "$disk_spill" != "success" && "$disk_spill" != "skipped" ]]; then
exit 1
fi

test-disk-spill:
name: Disk-spill tests
runs-on: ubuntu-latest
if: github.event_name != 'push' || github.actor != 'github-merge-queue[bot]'
steps:
- name: Checkout sources
uses: actions/checkout@v4

- name: Setup Rust Environment
uses: ./.github/actions/setup-rust

- name: Cache cargo build artifacts
uses: Swatinem/rust-cache@v2
with:
shared-key: "lambda-vm-disk-spill"
cache-all-crates: "true"

- name: Cache compiled ASM ELF artifacts
id: cache-asm-elfs
uses: actions/cache@v4
with:
path: executor/program_artifacts/asm
key: asm-elf-artifacts-${{ hashFiles('executor/programs/asm/**') }}

- name: Install clang and lld
if: steps.cache-asm-elfs.outputs.cache-hit != 'true'
run: sudo apt-get update && sudo apt-get install -y clang lld

- name: Compile ASM programs to ELF
if: steps.cache-asm-elfs.outputs.cache-hit != 'true'
run: |
make compile-programs-asm

- name: Cache compiled Rust ELF artifacts and build cache
id: cache-rust-elfs
uses: actions/cache@v4
with:
path: |
executor/program_artifacts/rust
executor/shared_target
key: rust-elf-artifacts-${{ hashFiles('executor/programs/rust/**', 'executor/programs/riscv64im-lambda-vm-elf.json', 'syscalls/**', 'Makefile') }}
restore-keys: |
rust-elf-artifacts-

- name: Compile Rust programs to ELF
if: steps.cache-rust-elfs.outputs.cache-hit != 'true'
run: |
make compile-programs-rust

- name: Run stark disk-spill tests
run: |
cargo test --release -p stark --features disk-spill disk_spill

- name: Run prover disk-spill tests
env:
FORCE_DISK_SPILL: "1"
run: |
cargo test --release -p lambda-vm-prover --features disk-spill -- disk_spill count_table_lengths

build-prover-tests:
name: Build prover tests
Expand Down
170 changes: 166 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading