Skip to content

spec: KECCAK accelerator#474

Merged
erik-3milabs merged 25 commits into
spec/mainfrom
spec/keccak
Apr 22, 2026
Merged

spec: KECCAK accelerator#474
erik-3milabs merged 25 commits into
spec/mainfrom
spec/keccak

Conversation

@erik-3milabs
Copy link
Copy Markdown
Collaborator

This PR adds:

  1. specification for a keccak accelerator
  2. spec support for modulus notation with a constant modulus
  3. spec support for multi-dimensional arrays

@erik-3milabs erik-3milabs requested a review from RobinJadoul April 1, 2026 13:46
@erik-3milabs erik-3milabs self-assigned this Apr 1, 2026
@erik-3milabs erik-3milabs added the spec Updates and improvements to the spec document label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Codex Code Review

  1. Low (Potential bug): mod expression support is inconsistent between checker and renderer
  • The checker accepts any constant expression as modulus (e.g. ["+", 4, 4]) in chip.py and builds it in chip.py.
  • The Typst renderers require the modulus to be a literal int via type(e.at(2)) == int in expr.typ and expr.typ.
  • Result: valid expressions for tooling/typecheck can fail during spec rendering.

No concrete security vulnerabilities, significant performance issues, or additional high-confidence bugs found in this PR diff.

Comment thread spec/expr.typ Outdated
Comment thread spec/expr.typ Outdated
Comment thread spec/keccak.typ Outdated
Comment thread spec/tooling/chip.py
Comment thread spec/tooling/chip.py Outdated
@yetanotherco yetanotherco deleted a comment from github-actions Bot Apr 2, 2026
Comment thread spec/src/keccak.toml Outdated
@yetanotherco yetanotherco deleted a comment from github-actions Bot Apr 7, 2026
Base automatically changed from spec/main to main April 10, 2026 13:13
@erik-3milabs erik-3milabs changed the base branch from main to spec/main April 10, 2026 14:50
Copy link
Copy Markdown
Collaborator

@RobinJadoul RobinJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and questions.
Confidence in several of them is fairly low, so feel free to tell me if I'm wrong somewhere :)

Comment thread spec/expr.typ Outdated
Comment thread spec/signatures.typ Outdated
Comment thread spec/src/keccak.toml
Comment thread spec/keccak.typ Outdated
Comment thread spec/src/keccak_round.toml
Comment thread spec/src/keccak.toml
Comment thread spec/src/keccak_round.toml Outdated
Comment thread spec/keccak.typ
Comment thread spec/tooling/chip.py Outdated
@erik-3milabs erik-3milabs merged commit d23f806 into spec/main Apr 22, 2026
2 checks passed
@erik-3milabs erik-3milabs deleted the spec/keccak branch April 22, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spec Updates and improvements to the spec document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants