Add support for web_sys in addition to stdweb#4
Open
Stigjb wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate depended on
stdweb, which is not desirable if you prefer to useweb-sys, like the main Yew project is moving to.Many of the examples in the Yew project depend on
web_logger, and therefore implicitly pull instdwebeven though they're supposed to beweb-sysonly. I assume they will benefit from smaller code size onceweb_loggercan useweb-sysas well.extern crateormacro_use)std_webas default feature to keep backward compatibilitySome diffs are entirely
cargo fmts doing.Questions
I'm not confident that I applied
pub(super)right in the respective modules, but I tried to mirror the original.I think it would be nice to provide a warning if someone were to try to install both features (which could happen if they forgot
default-features = false). Not sure how to do that. Because of the order ofcfg_if, this would build thestd_webmodule.