Trouble deserialising CBOR from a websocket message

[ntwl-xyz]

Description

I can't seem to deserialise a binary websocket message into CBOR.
The message i'm sending is a struct converted to a vec using serde_cbor.
https://gist.github.com/margh/eb805124d55a0adba2b95ff1428fba76#file-ws_example-rs-L80

If this line is changed to JSON the message is parsed fine, but the response becomes an error, i assume because the binary data can't be serialized into json.

I noticed there's no string format macro in this file, perhaps that is the cause of the trait not being fulfilled?:
https://github.com/DenisKolodin/yew/blob/master/src/format/cbor.rs#L17

Please bear with my sketchy code, I'm not sure if i'm using the formatter correctly in this case.

Expected Results

Message is encoded into a CBOR value I can later cast to a struct.

Actual Results

error[E0277]: the trait bound `yew::format::Cbor<std::result::Result<WsResponse, failure::Error>>: std::convert::From<std::result::Result<std::string::String, failure::Error>>` is not satisfied
  --> src/lib.rs:87:52
   |
87 |                         let task = self.ws_service.connect("ws://localhost:40000/", callback, notification);
   |                                                    ^^^^^^^ the trait `std::convert::From<std::result::Result<std::string::String, failure::Error>>` is not implemented for `yew::format::Cbor<std::result::Result<WsResponse, failure::Error>>`
   |
   = help: the following implementations were found:
             <yew::format::Cbor<std::result::Result<T, failure::Error>> as std::convert::From<std::result::Result<std::vec::Vec<u8>, failure::Error>>>

Context (Environment)

• Rust: nightly

• yew: v0.5.0

• target: wasm32-unknown-unknown

• cargo-web 0.6.15

[serzhiio]

you can look at my fork untill its not merged, ive implemented a quick workaround for this

[justacec]

So confused by this... I am getting this error. @serzhiio, I looked at your fork, but I cannot seem to find the commit that you used to get around this so I understand the issue better. Can you link in your specific commit that you used to implement a fix?

[jstarry]

@serzhiio can you fix this?

[rumblefrog]

I'm assuming this is the commit since it's the only diff on the branches: serzhiio@f252276

[ctm]

I ran into this issue last night when I was tired and I spent a bit of time chasing my tail before understanding what was going on.

I don't claim that my PR (#847) is the proper way forward, but it works for me. If there's a better way to do it, I'll be happy to help if I can, but it does seem like being able to use binary-only formats with WebSockets is worthwhile.

Similarly, I don't know that having a separate CborPacked is better than having some other way to request that to_vec_packed is used instead of to_vec.

I thought about submitting two PRs, but they would both be touching the same area of code, so I figure this is probably the getter way to proceed.