Adopt cargo-make#1541
Conversation
siku2
force-pushed
the
adopt-cargo-make
branch
from
ccd8d71 to
6dd01d0
Compare
also, that Geckodriver issue seems to be resolved
|
Partially resolves #1368 too. Next up, updating the examples. |
| dependencies = ["install-msrv-toolchain"] | ||
| script = [ | ||
| """ | ||
| cargo +${MSRV} test |
There was a problem hiding this comment.
@siku2 tasks can set the toolchain to work with using the toolchain attribute.
The value of that attribute is used by rustup to install if needed.
so you could do
[tasks.test]
toolchain = "1.45.2"
command = "cargo"
args = [ "test" ]see more info at https://github.com/sagiegurari/cargo-make#usage-toolchain
There was a problem hiding this comment.
Oh wow, you even used it in the original version and I still totally missed it 😅
I think I got confused by the rust_version condition which does something totally different.
I originally wanted to ask you for a review on this but I thought that would be an unreasonable thing to ask.
Anyway, thanks for pointing this out. That makes it a lot cleaner!
There was a problem hiding this comment.
@sagiegurari Finally got around to this! I noticed that unlike my little script, the toolchain setting won't attempt to automatically download the toolchain.
The error it generates is nice enough so I'm still going to use it but cargo-make already automatically downloads packages (which takes significantly longer because they need to be compiled) so I would expect it to do the same for toolchains. What do you think?
* remove getrandom from game_of_life I know the wasm-bindgen feature is deprecated but this is more convenient for now and all the other examples use it this way as well. We can update all of them in one go when rand 0.8 rolls around * update todomvc README * clean up yew-macro makefile See: #1541 (comment) * Use Firebase Hosting
3 participants
Description
Updates all the remaining things to adopt cargo-make as the new task runner instead of unportable bash scripts.
Closes #1504
TODO
tasks.benchfor yew is ignored by the flowtasks.testfor yew-macro should properly enforce the correct Rust version