Fix not removing readers in file upload example#2055
Merged
Conversation
In the file upload example we store the FileReaders while reading from the uploaded file but once read we never remove them from the vec.
|
Definitely better than just indefinitely leaving them in a |
Contributor
Author
|
My understanding is that you can't select directories without the webkitdirectory attribute which is not standard. So I think this is okay, though it was interesting because I didn't even know about |
Contributor
Author
|
Happy to merge? :) |
Member
|
If you don't want to press the button, I certainly enjoy doing so :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bit of deja vu for you but this fixes the same issue as #2054 but on
master:)In the file upload example we store the FileReaders while reading from
the uploaded file but once read we never remove them from the vec.
Closes #2035
Checklist
cargo make pr-flow