Fix router example.#2179
Merged
Merged
Conversation
voidpumpkin
previously approved these changes
Nov 22, 2021
Member
voidpumpkin
left a comment
voidpumpkin
left a comment
There was a problem hiding this comment.
Small optional nit-pick.
Otherwise LGTM
voidpumpkin
previously approved these changes
Nov 22, 2021
WorldSEnder
reviewed
Nov 22, 2021
Co-authored-by: WorldSEnder <WorldSEnder@users.noreply.github.com>
voidpumpkin
approved these changes
Nov 22, 2021
ranile
approved these changes
Nov 22, 2021
Member
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Looks good.
Why do the router state and action need to be pub(crate) instead of just being private? Are they used anywhere else?
Member
Author
Router state is also used in the following files: https://github.com/yewstack/yew/blob/master/packages/yew-router/src/scope_ext.rs#L91 https://github.com/yewstack/yew/blob/master/packages/yew-router/src/hooks.rs#L11 |
Member
Author
|
Action is due to it being an associated type of the reducible trait so it requires the same visibility as router state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes re-render issue where the direct descent of a
<Router>component is not re-rendered when it's children changes.Fixes #2168
Checklist
cargo make pr-flow