Skip to content

implement From<Cow<'static, str>> for AttrValue#2200

Merged
voidpumpkin merged 3 commits into
yewstack:masterfrom
Madoshakalaka:attr_val_from_cow_static
Nov 26, 2021
Merged

implement From<Cow<'static, str>> for AttrValue#2200
voidpumpkin merged 3 commits into
yewstack:masterfrom
Madoshakalaka:attr_val_from_cow_static

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

Description

Fixes #2198

Checklist

  • I have run cargo make pr-flow
  • I've linted code.
  • I have reviewed my own code
  • I have added tests

ranile
ranile previously approved these changes Nov 26, 2021
@ranile ranile requested a review from voidpumpkin November 26, 2021 04:58
Copy link
Copy Markdown
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidpumpkin voidpumpkin merged commit 83aa051 into yewstack:master Nov 26, 2021
@voidpumpkin voidpumpkin mentioned this pull request Nov 26, 2021
3 tasks
@Madoshakalaka Madoshakalaka deleted the attr_val_from_cow_static branch November 30, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the trait From<Cow<'_, str>> is not implemented for AttrValue

3 participants