Skip to content

Fix Getting Started link on home page#2226

Merged
ranile merged 1 commit into
masterfrom
hamza1311-patch-docs-link
Dec 1, 2021
Merged

Fix Getting Started link on home page#2226
ranile merged 1 commit into
masterfrom
hamza1311-patch-docs-link

Conversation

@ranile
Copy link
Copy Markdown
Member

@ranile ranile commented Nov 30, 2021

Description

Fixes #2224

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0075f1b):

https://yew-rs--pr2226-hamza1311-patch-docs-eqjjxin9.web.app

(expires Tue, 07 Dec 2021 10:33:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Madoshakalaka
Copy link
Copy Markdown
Member

OwO
The link would change the version to 0.19 no matter what version you are currently on

@Madoshakalaka
Copy link
Copy Markdown
Member

wait what, why is everybody approving, the link fixes the version to 0.19 NO MATTER WHAT. Say somebody is viewing the index page with selected version 0.18 or Next, clicking the Getting Started link will change his current version to 0.19.

@ranile
Copy link
Copy Markdown
Member Author

ranile commented Dec 1, 2021

wait what, why is everybody approving, the link fixes the version to 0.19 NO MATTER WHAT. Say somebody is viewing the index page with selected version 0.18 or Next, clicking the Getting Started link will change his current version to 0.19.

That is how it works on docusaurus.io too. Go go any version on their site that is on docusaurus.io and is not the latest version, and click the getting started button on the home page. Ideally, the home page shouldn't even show the version drop-down but docusaurus doesn't allow that (yet?) It's possible with swizzling though so if can make that work, that would be nice.

@Madoshakalaka
Copy link
Copy Markdown
Member

wait what, why is everybody approving, the link fixes the version to 0.19 NO MATTER WHAT. Say somebody is viewing the index page with selected version 0.18 or Next, clicking the Getting Started link will change his current version to 0.19.

That is how it works on docusaurus.io too. Go go any version on their site that is on docusaurus.io and is not the latest version, and click the getting started button on the home page. Ideally, the home page shouldn't even show the version drop-down but docusaurus doesn't allow that (yet?) It's possible with swizzling though so if can make that work, that would be nice.

oohh really...just checked on docusaurus and you are right. Somehow I remembered docusaurus' Getting Started is smart. Anyways, go ahead and merge then!

@ranile
Copy link
Copy Markdown
Member Author

ranile commented Dec 1, 2021

Somehow I remembered docusaurus' Getting Started is smart. Anyways, go ahead and merge then!

It is. In the sense that there is a page literally at /docs. See my comment on the issue about having better slugs. That (and swizzling) should address this

@ranile ranile merged commit e7009db into master Dec 1, 2021
@ranile ranile deleted the hamza1311-patch-docs-link branch December 1, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 "Getting Started" link on landing page

4 participants