Add example of function memory game#2313
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
siku2
left a comment
siku2
left a comment
There was a problem hiding this comment.
Nice, thanks for picking this up
| "examples/function_todomvc", | ||
| "examples/function_memory_game", |
There was a problem hiding this comment.
Sorted alphabetically:
| "examples/function_todomvc", | |
| "examples/function_memory_game", | |
| "examples/function_memory_game", | |
| "examples/function_todomvc", |
Hope I didn't mess up the indentation on my phone
| # rust-memory-game | ||
|
|
||
|
|
||
| A port version of [react-memory-game](https://github.com/leftstick/react-memory-game). You are able to try it at [here](https://img.shields.io/website?label=demo&url=https%3A%2F%2Fexamples.yew.rs%2Ffunction_memory_game)](https://examples.yew.rs/function_memory_game) |
There was a problem hiding this comment.
Can we adjust this to be more in line with the other examples? I.e. title, example badge.
Also that [here] markdown is all over the place.
| ## LICENSE | ||
|
|
||
| [MIT License](https://raw.githubusercontent.com/yewstack/yew/examples/function_memory_game/master/LICENSE) |
There was a problem hiding this comment.
Weird link and probably not really needed since the license isn't particular to this example, right?
There was a problem hiding this comment.
sure, it should be removed. Thanks for reminding
| <title>Yew • Function MemoryGame</title> | ||
| <base data-trunk-public-url/> |
There was a problem hiding this comment.
| <title>Yew • Function MemoryGame</title> | |
| <base data-trunk-public-url/> | |
| <title>Yew • Function Memory Game</title> | |
| <base data-trunk-public-url /> |
There was a problem hiding this comment.
Unless it's actually supposed to be stylised as MemoryGame...
|
|
||
| let get_link_by_cardname = { | ||
| match name { | ||
| CardName::EightBall => "public/8-ball.png", |
There was a problem hiding this comment.
Putting this here because I can't put it on the file directly.
Do we know the origin of these image assets? Or more importantly, the license?
There was a problem hiding this comment.
This is port version of Memory-Game. I will try to check with the author if it is possible we can use them Since he forgot to specify the license in his project.
Thanks for reminding me the issue
There was a problem hiding this comment.
@siku2 i got confirmed by the author, bradlygreen/Memory-Game#6. We are possible to use those images
|
Original PR was updated. Which one should we proceed with? |
|
@hamza1311 thanks for your review. I missed this PR, so that I will update code based on your comments in the original PR |
4 participants
Description
Original PR owner was not updating his PR so i just did it
Closes #2255
Checklist
cargo make pr-flow