Fix macro hygine issues#2585
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 6e76bf6): https://yew-rs-api--pr2585-update-macro-tests-3q1yr7my.web.app (expires Wed, 13 Apr 2022 19:22:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
|
WorldSEnder
approved these changes
Apr 6, 2022
Member
WorldSEnder
left a comment
There was a problem hiding this comment.
Not sure why mixed_site is needed on Token!s, but it can't hurt :)
Member
Author
I did a find and replace for I'm going to merge this. If it causes any problems, we can always revert it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
#![no_implicit_prelude]in macro tests. This ensures that:#[automatically_derived]and#[doc(hidden)]where missingSpan::call_site()withSpan::mixed_site()Fixes #1633
Checklist
cargo make pr-flow