Skip to content

Fix: check examples depending on lipsum for rust 1.56#2717

Merged
ranile merged 1 commit into
yewstack:masterfrom
WorldSEnder:pin-lipsum
Jun 4, 2022
Merged

Fix: check examples depending on lipsum for rust 1.56#2717
ranile merged 1 commit into
yewstack:masterfrom
WorldSEnder:pin-lipsum

Conversation

@WorldSEnder
Copy link
Copy Markdown
Member

@WorldSEnder WorldSEnder commented Jun 4, 2022

Description

Fixes #2710

As a workaround for the lipsum update not working with our current MSRV, pin it to the previous one.
Targets CI working again.

Checklist

  • I have reviewed my own code

@WorldSEnder WorldSEnder marked this pull request as ready for review June 4, 2022 10:40
@WorldSEnder WorldSEnder changed the title Fix: examples depending on lipsum for rust 1.56 Fix: check examples depending on lipsum for rust 1.56 Jun 4, 2022
@WorldSEnder WorldSEnder added A-examples Area: The examples A-ci Area: The continuous integration labels Jun 4, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2022

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
boids 172.945 172.945 0 0.000%
contexts 109.752 109.752 0 0.000%
counter 86.719 86.719 0 0.000%
counter_functional 87.370 87.370 0 0.000%
dyn_create_destroy_apps 89.836 89.836 0 0.000%
file_upload 102.794 102.794 0 0.000%
function_memory_game 167.394 167.394 0 0.000%
function_router 350.514 350.293 -0.221 -0.063%
function_todomvc 162.067 162.067 0 0.000%
futures 227.126 227.126 0 0.000%
game_of_life 107.707 107.707 0 0.000%
inner_html 83.788 83.788 0 0.000%
js_callback 112.968 112.968 0 0.000%
keyed_list 195.264 195.264 0 0.000%
mount_point 86.350 86.350 0 0.000%
nested_list 116.093 116.093 0 0.000%
node_refs 90.539 90.539 0 0.000%
password_strength 1538.629 1538.629 0 0.000%
portals 97.356 97.356 0 0.000%
router 319.478 319.245 -0.232 -0.073%
simple_ssr 153.693 153.693 0 0.000%
ssr_router 395.934 395.686 -0.248 -0.063%
suspense 110.611 110.611 0 0.000%
timer 89.429 89.429 0 0.000%
todomvc 143.127 143.127 0 0.000%
two_apps 87.328 87.328 0 0.000%
web_worker_fib 153.575 153.575 0 0.000%
webgl 87.610 87.610 0 0.000%

✅ None of the examples has changed their size significantly.

@WorldSEnder WorldSEnder requested review from futursolo and ranile June 4, 2022 11:39
@ranile ranile enabled auto-merge (squash) June 4, 2022 11:40
@WorldSEnder
Copy link
Copy Markdown
Member Author

WorldSEnder commented Jun 4, 2022

Auto approve didn't run because I initially unintentionally created the PR as draft and it doesn't seem to re-trigger when converting to ready to review.

@ranile ranile merged commit e196156 into yewstack:master Jun 4, 2022
@WorldSEnder WorldSEnder deleted the pin-lipsum branch June 4, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: The continuous integration A-examples Area: The examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lipsum library doesn't work with rust 1.56

3 participants