fix: link all outstanding TODO items to a ticket#949
Merged
Conversation
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
b7795ea to
5737252
Compare
Member
|
I'm fine with the warnings, thanks so much for doing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #800
Note: as pointed out in #800,
report_todoandreport_fixmeare only available on the nightly channel. If you're on the stable channel, you will see a ton of error messages any time you runcargo fmt. Perhaps these should be commented out? Let me know how you'd like to proceed here.Signed-off-by: Matthew Fisher matt.fisher@microsoft.com