cargo clippy failed for web-sys feature

[jetli]

Describe the Bug
cargo clippy failed on v0.10.0 when using web-sys feature

To Reproduce
Clone https://github.com/jetli/rust-yew-realworld-example-app and run clippy

cargo clippy -- --deny=warnings

   Compiling yew-router v0.10.0
error: failed to run custom build command for `yew-router v0.10.0`

Caused by:
  process didn't exit successfully: `/Users/jetli/repos/_jetli/rust-yew-realworld-example-app/target/debug/build/yew-router-bc27cefeee4a23ab/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Selected target `x86_64-apple-darwin` is not compatible with web-sys', /Users/jetli/.cargo/registry/src/github.com-1ecc6299db9ec823/yew-router-0.10.0/build.rs:25:9

Related Info

• yew version: 0.13.0
• yew-router version: 0.10.0

[jetli]

Related to this PR: yewstack/yew#982

[hgzimmerman]

Yeah, I haven't considered clippy usage when enabling web_sys/std_web support.
I would suppose that the build.rs needs to be updated to match that of yew's per your linked PR.

[jetli]

Tried to copy build.rs from yew, but a new error occurs:

Checking yew-router v0.10.0 (/Users/jetli/repos/_jetli/yew_router)
error: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
   --> /Users/jetli/repos/_jetli/yew_router/src/service.rs:188:41
    |
188 |             .and_then(|state_string| -> Option<Option<STATE>>{
    |                                         ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::option-option` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option

[hgzimmerman]

If you are creating a PR for this, you are welcome to place #[allow(...)] annotations to get it to pass clippy's lint. I'll accept the PR with those annotations and investigate them later if they warrant it.

[jetli]

Just sent a PR :), I copied build.rs from yew and tried to fix the double Option.
It works for now for my project.

[hgzimmerman]

Thanks!