Skip to content
This repository was archived by the owner on Jul 19, 2020. It is now read-only.

Fix RouterAnchor href#228

Merged
hgzimmerman merged 1 commit into
yewstack:masterfrom
jetli:feature/fix_anchor_href
Jan 22, 2020
Merged

Fix RouterAnchor href#228
hgzimmerman merged 1 commit into
yewstack:masterfrom
jetli:feature/fix_anchor_href

Conversation

@jetli
Copy link
Copy Markdown
Contributor

@jetli jetli commented Jan 22, 2020

Fix #225

@jetli
Copy link
Copy Markdown
Contributor Author

jetli commented Jan 22, 2020

@hgzimmerman and should we fix this and release a v0.8.2 or wait for v0.9? I'm thinking if this issue is a show stopper or not, because <a> loses href and default css style cursor: pointer; or underline etc., it's not like an anchor on web page.

@hgzimmerman
Copy link
Copy Markdown
Member

Yeah, I'm in favor of a v0.8.2 release.

I think that I may want to use a flag that can be set to cause this change to not be in effect - but that can wait for a v0.9.0 release. I think it being anchor-like should be the default.

I'll look into this after work.

@hgzimmerman hgzimmerman merged commit 0e0f9cb into yewstack:master Jan 22, 2020
@jetli jetli deleted the feature/fix_anchor_href branch January 22, 2020 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RouterAnchor does not generate href for <a>

2 participants