This repository was archived by the owner on Jul 19, 2020. It is now read-only.
Undo non-passive state for prevent_default#240
Merged
Conversation
Member
|
With CI approving and the corresponding change made in Yew being merged, I'm going to go ahead and merge this. |
Contributor
|
@jetli Thanks, this is exactly what was needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jstarry decided that we should fix prevent_default on the yew side: yewstack/yew#952, and I sent a PR for that: yewstack/yew#958, so on the yew_router side, we can undo some codes which deals with non-passive problem for prevent_default.
@hgzimmerman @tarkah please help review.