Skip to content

Conversation

@alapre
Copy link
Contributor

@alapre alapre commented Aug 22, 2024

Increase beta version of search-headless (and search-headless-react) to correctly support function vertical.

Test: auto
ran npm run test and all tests passed.

@alapre alapre requested a review from a team as a code owner August 22, 2024 14:37
"eslint-plugin-react-perf": "^3.3.1",
"eslint-plugin-tsdoc": "^0.2.14",
"generate-license-file": "^1.3.0",
"generate-license-file": "^3.5.0",
Copy link
Contributor Author

@alapre alapre Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging that I also increased generate-license-file from 1.3.0 to 3.5.0 in order to npm run build without getting errors.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good!

@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

coverage: 94.34%. remained the same
when pulling e3cccbc on dev/function-vertical-testing-dev
into fd107df on develop.

@alapre alapre requested review from Fondryext and vijay267 August 22, 2024 14:40
@alapre alapre merged commit 27184cd into develop Aug 22, 2024
Fondryext added a commit that referenced this pull request Feb 20, 2025
This PR bridges the now-released GDA version of search-headless. Full chain below (mostly merges from main into develop)

* Update CODEOWNERS (#200)

* update search-headless dependencies version to 2.6.0-beta (#201)

Update search-core and search-headless versions to 2.6.0-beta which introduce support for Generative Direct Answer

J=CLIP-1226
TEST=auto

ran `npm run test`

* update search-headless dependencies version to 2.6.0-beta.2 (#202)

New version clears gda state response on error

J=CLIP-1226
TEST=auto

ran `npm run test`

* update search-headless dependencies version to 2.6.0-beta.3 (#203)

New version has `queryDurationMillis` as an optional field of VerticalResults

J=CLIP-1226
TEST=auto

ran `npm run test`

* update search-headless dependencies version to 2.6.0-beta.4

The new beta version has the isPagination variable which
upstream beta dependencies of search-headless-react require.

J=none
TEST=auto

ran npm run test

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Up package beta version

* search-headless-react: increase beta version ref of search-headless (#205)

* up beta version number and ref to search-headless for function vertical

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Update package.json

* Update package-lock.json

* fix package lock

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Upgrade to non-beta versions

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

---------

Co-authored-by: nmanu1 <88398086+nmanu1@users.noreply.github.com>
Co-authored-by: EmilyZhang777 <48967088+EmilyZhang777@users.noreply.github.com>
Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anna Lapre <98433280+alapre@users.noreply.github.com>
Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com>
Fondryext added a commit that referenced this pull request Apr 7, 2025
* v2.5.0

This PR bridges the now-released GDA version of search-headless. Full chain below (mostly merges from main into develop)

* Update CODEOWNERS (#200)

* update search-headless dependencies version to 2.6.0-beta (#201)

Update search-core and search-headless versions to 2.6.0-beta which introduce support for Generative Direct Answer

J=CLIP-1226
TEST=auto

ran `npm run test`

* update search-headless dependencies version to 2.6.0-beta.2 (#202)

New version clears gda state response on error

J=CLIP-1226
TEST=auto

ran `npm run test`

* update search-headless dependencies version to 2.6.0-beta.3 (#203)

New version has `queryDurationMillis` as an optional field of VerticalResults

J=CLIP-1226
TEST=auto

ran `npm run test`

* update search-headless dependencies version to 2.6.0-beta.4

The new beta version has the isPagination variable which
upstream beta dependencies of search-headless-react require.

J=none
TEST=auto

ran npm run test

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Up package beta version

* search-headless-react: increase beta version ref of search-headless (#205)

* up beta version number and ref to search-headless for function vertical

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Update package.json

* Update package-lock.json

* fix package lock

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

* Upgrade to non-beta versions

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

---------

Co-authored-by: nmanu1 <88398086+nmanu1@users.noreply.github.com>
Co-authored-by: EmilyZhang777 <48967088+EmilyZhang777@users.noreply.github.com>
Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anna Lapre <98433280+alapre@users.noreply.github.com>
Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com>

* v2.5.1: Upgrade React to v18, bump search-headless (#218)

Upgrading React to align with search-ui-react. Also bumps search-headless
to pick up Dev/QA endpoint changes.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check

---------

Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com>
Co-authored-by: nmanu1 <88398086+nmanu1@users.noreply.github.com>
Co-authored-by: EmilyZhang777 <48967088+EmilyZhang777@users.noreply.github.com>
Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anna Lapre <98433280+alapre@users.noreply.github.com>
Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com>
Co-authored-by: Jacob Fondriest <jfondriest@yext.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants