-
Notifications
You must be signed in to change notification settings - Fork 13
feat: upgrade to React 19; add backwards compatibility test-site script (v1.11.0) #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Current unit coverage is 90.49066435084673% |
mkouzel-yext
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! I just had a few questions to help me understand what parts of this PR are doing.
vijay267
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some minor comments, but generally looks good
Add support for React 19. Following this upgrade for
search-headless-react: yext/search-headless-react#237.Also adds a script for testing backwards compatibility in the test site.
J=WAT-4947
TEST+auto, manual
Auto: all tests pass
Manual: spun up test site with new version as well as React 18.