In FilterableDataInterface::withFilterHandlers() rename parameter to $filterHandlers + Fix bc.yml

.github/workflows/bc.yml

@@ -3,13 +3,12 @@ on:
   - push
 
 name: backwards compatibility
+
 jobs:
   roave_bc_check:
-    name: Roave BC Check
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@master
-      - name: fetch tags
-        run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
-      - name: Roave BC Check
-        uses: docker://nyholm/roave-bc-check-ga
+    uses: yiisoft/actions/.github/workflows/bc.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

CHANGELOG.md

@@ -2,8 +2,9 @@
 
 ## 1.0.1 under development
 
-- no changes in this release.
+- Chg #137: In `FilterableDataInterface::withFilterHandlers()` rename parameter `$iterableFilterHandlers` to
+  `$filterHandlers` (@vjik)
 
 ## 1.0.0 January 14, 2023
 
-- Initial release.
+- Initial release.

src/Reader/FilterableDataInterface.php

@@ -30,10 +30,10 @@ public function withFilter(FilterInterface $filter): static;
     /**
      * Returns new instance with additional handlers set.
      *
-     * @param FilterHandlerInterface ...$iterableFilterHandlers Additional iterable handlers.
+     * @param FilterHandlerInterface ...$filterHandlers Additional filter handlers.
      *
      * @return static New instance.
      * @psalm-return $this
      */
-    public function withFilterHandlers(FilterHandlerInterface ...$iterableFilterHandlers): static;
+    public function withFilterHandlers(FilterHandlerInterface ...$filterHandlers): static;
 }

src/Reader/Iterable/IterableDataReader.php

@@ -88,12 +88,12 @@ public function __construct(private iterable $data)
     /**
      * @psalm-return $this
      */
-    public function withFilterHandlers(FilterHandlerInterface ...$iterableFilterHandlers): static
+    public function withFilterHandlers(FilterHandlerInterface ...$filterHandlers): static
     {
         $new = clone $this;
         $new->iterableFilterHandlers = array_merge(
             $this->iterableFilterHandlers,
-            $this->prepareFilterHandlers($iterableFilterHandlers)
+            $this->prepareFilterHandlers($filterHandlers)
         );
         return $new;
     }

tests/Paginator/KeysetPaginatorTest.php

@@ -532,7 +532,7 @@ public function withFilter(FilterInterface $filter): static
                 return clone $this;
             }
 
-            public function withFilterHandlers(FilterHandlerInterface ...$iterableFilterUnits): static
+            public function withFilterHandlers(FilterHandlerInterface ...$filterHandlers): static
             {
                 return clone $this;
             }