Conversation
Member
vjik
commented
Jan 16, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 254 261 +7
===========================================
Files 35 36 +1
Lines 634 668 +34
===========================================
+ Hits 634 668 +34 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/Paginator/KeysetPaginator.php
vjik
added
status:code review
vjik
added
status:under discussion
status:under development
# Conflicts: # src/Paginator/KeysetPaginator.php
vjik
changed the title
KeysetPaginatorKeysetPaginator and new method Compare::withValue()
vjik
added
status:code review
samdark
reviewed
Jan 17, 2024
samdark
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.