Skip to content

Fix sort configuration and criteria preparation#155

Merged
vjik merged 5 commits intomasterfrom
fix-sort
Jan 22, 2024
Merged

Fix sort configuration and criteria preparation#155
vjik merged 5 commits intomasterfrom
fix-sort

Conversation

@vjik
Copy link
Member

@vjik vjik commented Jan 22, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️

@vjik vjik requested a review from a team January 22, 2024 12:49
@vjik vjik added the status:code review The pull request needs review. label Jan 22, 2024
CHANGELOG.md Outdated
Comment on lines 12 to 13
- Fix #155: Fix `Sort` configuration preparation (@vjik)
- Chg #155: Same order fields in current order in `Sort` override previous now (@vjik)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix #155: Fix `Sort` configuration preparation (@vjik)
- Chg #155: Same order fields in current order in `Sort` override previous now (@vjik)
- Bug #155: Fix same named order fields in `Sort` were not overriding previous ones (@vjik)

@vjik vjik merged commit bef4fde into master Jan 22, 2024
@vjik vjik deleted the fix-sort branch January 22, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants