Conversation
Member
vjik
commented
Jan 23, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
vjik
changed the title
PaginatorInterface::withSort()PaginatorInterface::isSupportSorting() and PaginatorInterface::withSort()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 270 275 +5
===========================================
Files 36 36
Lines 682 696 +14
===========================================
+ Hits 682 696 +14 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jan 23, 2024
src/Paginator/KeysetPaginator.php
Outdated
| return $this->isOnLastPage() ? null : $this->currentLastValue; | ||
| } | ||
|
|
||
| public function isSupportSorting(): bool |
Member
There was a problem hiding this comment.
Suggested change
| public function isSupportSorting(): bool | |
| public function isSortable(): bool |
vjik
changed the title
PaginatorInterface::isSupportSorting() and PaginatorInterface::withSort()PaginatorInterface::isSortable() and PaginatorInterface::withSort()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.