Skip to content

Add methods PaginatorInterface::isFilterable() and PaginatorInterface::withFilter()#164

Merged
vjik merged 5 commits intomasterfrom
paginator-filter
Feb 19, 2024
Merged

Add methods PaginatorInterface::isFilterable() and PaginatorInterface::withFilter()#164
vjik merged 5 commits intomasterfrom
paginator-filter

Conversation

@vjik
Copy link
Member

@vjik vjik commented Feb 19, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Feb 19, 2024

PR Summary

  • Introduction of Filterability in Pagination
    The means to check if pagination can be filtered and a way to apply a filter have been added. These functionalities are implemented in both KeysetPaginator and OffsetPaginator.

  • Testing of New Filter Functions
    Tests have been added to verify the working of the new filter functions in both types of paginators.

  • Update in Change Log
    The recent changes have been documented in the CHANGELOG.md to keep track of product evolution.

@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5d1ba3) 100.00% compared to head (fd35039) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #164   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       276       281    +5     
===========================================
  Files             38        38           
  Lines            702       716   +14     
===========================================
+ Hits             702       716   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team February 19, 2024 12:44
@vjik vjik added the status:code review The pull request needs review. label Feb 19, 2024
@vjik vjik merged commit 9dc5d3a into master Feb 19, 2024
@vjik vjik deleted the paginator-filter branch February 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants