Skip to content

Remove EqualsEmpty filter#166

Merged
vjik merged 1 commit intomasterfrom
rm-equals-empty
Feb 25, 2024
Merged

Remove EqualsEmpty filter#166
vjik merged 1 commit intomasterfrom
rm-equals-empty

Conversation

@vjik
Copy link
Member

@vjik vjik commented Feb 24, 2024

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues -

"Empty" is very ambiguous concept and it depends from implementation.

@vjik vjik requested a review from a team February 24, 2024 11:35
@vjik vjik added the status:code review The pull request needs review. label Feb 24, 2024
@codecov
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9dc5d3a) to head (bc35a26).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #166   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       281       275    -6     
===========================================
  Files             38        36    -2     
  Lines            716       701   -15     
===========================================
- Hits             716       701   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit f0feee5 into master Feb 25, 2024
@vjik vjik deleted the rm-equals-empty branch February 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants